Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translated chapters 1-4 of the Rust tour in Romanian 🇷🇴 #3

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Translated chapters 1-4 of the Rust tour in Romanian 🇷🇴 #3

wants to merge 6 commits into from

Conversation

RaresCon
Copy link

No description provided.

@alexandruradovici alexandruradovici changed the title Translated the second chapter of the Rust tour in Romanian Translated chapters 2-5 of the Rust tour in Romanian Jan 16, 2023
alexandruradovici
alexandruradovici requested changes Jan 16, 2023
View reviewed changes
Copy link

@alexandruradovici alexandruradovici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest splitting every chapter in a separate pull request so that we can review it easier.

lessons/ro/chapter_1.yaml Outdated Show resolved Hide resolved
@alexandruradovici alexandruradovici changed the title Translated chapters 2-5 of the Rust tour in Romanian Translated chapters 1-4 of the Rust tour in Romanian Jan 16, 2023
alexandruradovici
alexandruradovici requested changes Jan 16, 2023
View reviewed changes
Copy link

@alexandruradovici alexandruradovici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the first person plural and the polite way of addressing users.

lessons/ro/chapter_1.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_1.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_1.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_1.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_1.yaml Outdated Show resolved Hide resolved
@RaresCon
Copy link
Author

I will reread every chapter and fix the addressing mistakes.

@RaresCon
Fixed addressing mistakes and translated Rust Playground snippets
0b68570 
I translated all code snippets from Rust Playground and fixed all
addressing mistakes (I hope) in Chapters 1-4. I will no longer add
new Chapters in this PR, as I will open a new PR for each new chapter.
@alexandruradovici
Copy link

Looks good.

@RaresCon RaresCon marked this pull request as ready for review January 17, 2023 16:32
@RaresCon
Copy link
Author

Would you like me to open 3 other PRs for chapters 2-4?

@alexandruradovici
Copy link

alexandruradovici commented Jan 18, 2023 •
edited
Loading

Would you like me to open 3 other PRs for chapters 2-4?

No, this looks good. Please send the PR to upstream and post a link to it.

alexandruradovici
alexandruradovici requested changes Jan 18, 2023
View reviewed changes
Copy link

@alexandruradovici alexandruradovici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review a little bit the translation, some things do not sound good in Romanian.

lessons/ro/chapter_1.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_2.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_2.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_2.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_3.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_4.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_4.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_4.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_4.yaml Outdated Show resolved Hide resolved
lessons/ro/chapter_3.yaml Outdated Show resolved Hide resolved
@RaresCon
Copy link
Author

I will read the chapters again and rewrite some parts, thank you!

alexandruradovici
alexandruradovici approved these changes Jan 23, 2023
View reviewed changes
Copy link

@alexandruradovici alexandruradovici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please send this to upstream, and post a link to it here.

@RaresCon RaresCon mentioned this pull request Jan 23, 2023
Merged
@RaresCon
Copy link
Author

richardanaya#455

@alexandruradovici alexandruradovici added the upstream This pull request was opened in the upstream repository label Jan 23, 2023
@alexandruradovici alexandruradovici changed the title Translated chapters 1-4 of the Rust tour in Romanian Translated chapters 1-4 of the Rust tour in Romanian 🇷🇴 Jan 27, 2023
@alexandruradovici
Copy link

I suggest adding the Romanian flag 🇷🇴 (copy paste) to the upstream pull request title.

veraradovici
veraradovici reviewed Feb 4, 2023
View reviewed changes
lessons/ro/chapter_1.yaml Show resolved Hide resolved
lessons/ro/chapter_1.yaml Show resolved Hide resolved
lessons/ro/chapter_1.yaml Show resolved Hide resolved
lessons/ro/chapter_1.yaml Show resolved Hide resolved
lessons/ro/chapter_1.yaml Show resolved Hide resolved
lessons/ro/chapter_1.yaml Show resolved Hide resolved
lessons/ro/chapter_1.yaml Show resolved Hide resolved
lessons/ro/chapter_1.yaml Show resolved Hide resolved
lessons/ro/chapter_1.yaml Show resolved Hide resolved
lessons/ro/chapter_1.yaml Show resolved Hide resolved
veraradovici
veraradovici reviewed Feb 4, 2023
View reviewed changes
lessons/ro/chapter_2.yaml Show resolved Hide resolved
lessons/ro/chapter_2.yaml Show resolved Hide resolved
lessons/ro/chapter_2.yaml Show resolved Hide resolved
lessons/ro/chapter_2.yaml Show resolved Hide resolved
lessons/ro/chapter_2.yaml Show resolved Hide resolved
lessons/ro/chapter_2.yaml Show resolved Hide resolved
lessons/ro/chapter_2.yaml Show resolved Hide resolved
lessons/ro/chapter_2.yaml Show resolved Hide resolved
lessons/ro/chapter_2.yaml Show resolved Hide resolved
lessons/ro/chapter_2.yaml Show resolved Hide resolved
@alexandruradovici
Copy link

@RaresCon please make the suggested changes to each chapter and submit with each one a pull request to upstream.

veraradovici
veraradovici reviewed Feb 4, 2023
View reviewed changes
lessons/ro/chapter_3.yaml Show resolved Hide resolved
lessons/ro/chapter_3.yaml Show resolved Hide resolved
lessons/ro/chapter_3.yaml Show resolved Hide resolved
lessons/ro/chapter_3.yaml Show resolved Hide resolved
lessons/ro/chapter_3.yaml Show resolved Hide resolved
lessons/ro/chapter_3.yaml Show resolved Hide resolved
lessons/ro/chapter_3.yaml Show resolved Hide resolved
lessons/ro/chapter_3.yaml Show resolved Hide resolved
lessons/ro/chapter_3.yaml Show resolved Hide resolved
lessons/ro/chapter_3.yaml Show resolved Hide resolved
@RaresCon
Copy link
Author

RaresCon commented Feb 4, 2023

@RaresCon please make the suggested changes to each chapter and submit with each one a pull request to upstream.

Will do as fast as possible.

veraradovici
veraradovici reviewed Feb 5, 2023
View reviewed changes
lessons/ro/chapter_4.yaml Show resolved Hide resolved
lessons/ro/chapter_4.yaml
dacă are nevoie de ajutor,

puteți oricând să instanțiați explicit folosind operatorul `::<T>`, cunoscut sub numele de
`turbofish` (e un bun prieten de-ai mei!).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`turbofish` (e un bun prieten de-ai mei!).
`turbofish` (e un bun prieten de-al meu!).

Copy link
Author

@RaresCon RaresCon Feb 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the phrase is grammatically correct.

lessons/ro/chapter_4.yaml Show resolved Hide resolved
lessons/ro/chapter_4.yaml Show resolved Hide resolved
lessons/ro/chapter_4.yaml Show resolved Hide resolved
lessons/ro/chapter_4.yaml Show resolved Hide resolved
lessons/ro/chapter_4.yaml Show resolved Hide resolved
lessons/ro/chapter_4.yaml Show resolved Hide resolved
lessons/ro/chapter_4.yaml Show resolved Hide resolved
lessons/ro/chapter_4.yaml Show resolved Hide resolved
@alexandruradovici
Copy link

@RaresCon Please select a timeslot for the interview https://doodle.com/meeting/participate/id/eZ8gOOEb.

@RaresCon
Copy link
Author

RaresCon commented Feb 7, 2023 •
edited
Loading

Chapter 1 PR is on upstream.

@alexandruradovici
Copy link

alexandruradovici commented Feb 7, 2023 •
edited
Loading

Please set to resolved the discussions that we can close.

@RaresCon
Copy link
Author

RaresCon commented Feb 9, 2023

Chapter 2 PR is on upstream. I hope to resolve Chapter 3 and 4 by Monday.

@RaresCon
Copy link
Author

RaresCon commented Feb 18, 2023 •
edited
Loading

Chapter 3 and 4 PRs are on upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alx-sima alx-sima alx-sima left review comments

@veraradovici veraradovici veraradovici left review comments

@alexandruradovici alexandruradovici alexandruradovici approved these changes

Assignees
No one assigned
Labels
upstream This pull request was opened in the upstream repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RaresCon @alexandruradovici @veraradovici @alx-sima