Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ch6 with note for OS #14

Closed
wants to merge 3 commits into from
Closed

add ch6 with note for OS #14

wants to merge 3 commits into from

Conversation

TabWilliams20
Copy link
Collaborator

@TabWilliams20 TabWilliams20 commented Jun 5, 2023

Minor addition of why we would want to look at previous commits. Addresses #8

Copy link
Collaborator

@brandonkopp brandonkopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I waffled about whether this lesson is necessary. I think it is important for people to be able to view the file differences and to possibly roll back, but I don't know that I would want anyone to think they had to do that at the command-line. This is one area where I would be more likely to use a GUI. That would make this section too different from the others, so I am comfortable leaving it as is. But maybe we could add a section at the end about there being GUI tools that can help with this?

Most of my comments were about the format of these more substantive lessons. If you think those comments make sense, maybe we can have a larger discussion and apply those choices to all lessons.

_episodes/06-exploring_history.md Outdated Show resolved Hide resolved
So, to put it all together,
here's how Git works in cartoon form:

![https://figshare.com/articles/How_Git_works_a_cartoon/1328266](fig/git_staging.svg)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a very good graphic. It takes a lot of mental effort (and git knowledge that people may have by this point in the lessons) to understand. We can consider replacing with something more straightforward (and not 3D).

Needs an alt tag.

_episodes/06-exploring_history.md Show resolved Hide resolved
If the introduction and conclusion are stored in separate files,
on the other hand,
moving backward and forward in time becomes much easier.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too it would be good to have a heading saying that this is the "Knowledge Check" section or something like that.

_episodes/06-exploring_history.md Outdated Show resolved Hide resolved
@thoughthollow
Copy link
Collaborator

I'm closing this pull request as I need to close all pull requests when transitioning the lesson format (for reference: https://carpentries.github.io/sandpaper-docs/migrating-from-styles.html)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants