ACCORD/IAL changes to PHYEX in CY49T1 #54
Conversation
21d95b428e Merge remote-tracking branch 'antoinettealiasMF/alias_CY49T0_gmgec' into accord_CY49T0_to_T1 e1f45ecf4c Workaround for NVHPC 23.11 4ef4a377db Merge remote-tracking branch 'BertvanUlft/ulft_CY49T0_HIRLAM_physics_aerosol' into accord_CY49T0_to_T1 302034816c Merge remote-tracking branch 'pmarguinaud/rapsgpu' into accord_CY49T0_to_T1 5a2cc52214 add a comment b1dc74233b re-instate broken vectorization 79925fce8f Merge remote-tracking branch 'romick-knmi/romick-knmi_CY49T0_HIRLAM_tech_contrib_3' into accord_CY49T0_to_T1 bdab329b73 Merge branch 'honnert_CY49_TURB3D' into accord_CY49T0_to_T1 0115fffb54 turb optimizations 74b59a5680 Merge remote-tracking branch 'SebastienRietteMTO/riette_CY49T1PHYEX_bf' into accord_CY49T0_to_T1 0a2bccab62 Merge remote-tracking branch 'RachelHonnert/honnert_CY49_LS18' into accord_CY49T0_to_T1 3d39e3c59d Merge remote-tracking branch 'YannSeity/seity_CY49_from48t1op' into accord_CY49T0_to_T1 23276ac69b remove LMNHLEONARD 8b0cdd0bb0 Merge branch 'accord_CY49T0_bf' into accord_CY49T0_to_T1 be9be2a97c S. Riette comments 1e52eb3fc4 rename LBL89ARP into LBL89TOP and optimize associated code ee310cefe5 Merge remote-tracking branch 'gh-SebastienRietteMTO/riette_CY49T0PHYEX_optim' into accord_CY49T0_to_T1 64b53509ed bug in fypp 93a4e77a6c bug interface structure 81124b3226 Set-up modifications 5c4ba693bb compilation bugs cdf9bcc9cf TURB3D modifications with PHYEX and GPU 07301cbd08 LGZ already in accord_CY49T0_to_T1/ change comment cb4d2aef56 modifs compilation et ajout LBL89ARP dans NAM_TURBn et bl89.F90 bb470178ce merge with the following 48t1_op arome branches : seity_CY48T1_op0.04%physArome seity_CY48T1_op1.02_cheks_apl_arome seity_CY48T1_op1.03_bf_STAT_arome seity_CY48T1_op1.04_LITOTC seity_CY48T1_op1.06_bfLITOTC seity_CY48T1_op1.05_LimitTendQ 3c73227c02 Merge remote-tracking branch 'gh-SebastienRietteMTO/riette_CY49T0_PHYEX_integration' into mf_CY49T0_raps
|
Hi @AlexandreMary, After discussion with @QuentinRodier, the files concerning aerosols should eventually go to ACLIB and not to PHYEX. While waiting for the externalisation of these codes, they should be put in mpa/chem (all the new files of your PR). Also, there is a small dependency with PHYEX because of the LAEIFN key declared in modd_nrt_aerosols and used in mode_rain_ice_old_nucleation. We have to pass the key as a dummy argument of the microphysics. Do you have any plans to release a 49T2_bf.01 version? If so, maybe we can introduce these modifications (moving the aerosol files and passing the key as an argument) and then you make a new PR based on it? If there is no 49T2_bf.01, I suggest you modify your PR to remove the aerosol files and I will have an AROME specific version of the nucleation routine in the PHYEX repository. |
AlexandreMary
force-pushed
the
arome_474b516_to_ACCORD49T1
branch
from
640d430 to
b57e83a
Compare
AlexandreMary
changed the title
|
OK I moved them back to mpa/ atop IAL The rebase of CY49T2 changes will be in another PR atop of this branch. |
Corresponding commits in IAL repo listed in the commit message.