feat: add excluded tokens in osnap llama adapter config #4553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Maldonado <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
Reinis-FRP
approved these changes
May 9, 2023
mrice32
reviewed
May 9, 2023
| "0x0391d2021f89dc339f60fff84546ea23e337750f", | ||
| "0x64aa3364f17a4d01c6f1751fd97c2bd3d7e7f1d5", | ||
| "0x03ab458634910aad20ef5f1c8ee96f1d6ac54919", | ||
| "0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2", |
There was a problem hiding this comment.
Isn't WETH already in the list? Would adding it twice double count the WETH? If so, maybe we should force-format the tokens in this list and eliminate duplicates in the script that reads this just to be sure that never happens.
There was a problem hiding this comment.
Thanks @mrice32,
My new commit in DefiLlama removes duplicates but that's a good catch
Signed-off-by: Pablo Maldonado <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
DefiLlama wants us to remove issued tokens from avatars DefiLlama/DefiLlama-Adapters#6097
Summary
Add excluded tokens list for each avatar