Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting to GitHub Actions #142

Closed

Conversation

alexdaniel654
Copy link
Member

Moving from pep8speaks to a github action. This PR will probably end up with lots of annoying commits when I'm testing it.

Should close #140

@pep8speaks
Copy link

pep8speaks commented May 6, 2021

Hello @alexdaniel654, thank you for updating!

Line 34:39: E251 unexpected spaces around keyword / parameter equals
Line 34:41: E251 unexpected spaces around keyword / parameter equals
Line 90:22: E225 missing whitespace around operator

Comment last updated at 2021-05-06 17:45:22 UTC

@UKRIN-MAPS-PEP8SPEAKS
Copy link

UKRIN-MAPS-PEP8SPEAKS commented May 6, 2021

Hello @alexdaniel654, thank you for updating!

Line 34:39: E251 unexpected spaces around keyword / parameter equals
Line 34:41: E251 unexpected spaces around keyword / parameter equals
Line 90:22: E225 missing whitespace around operator

Comment last updated at 2021-05-06 17:45:29 UTC

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #142 (8179ea9) into master (317ec9f) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   92.53%   92.69%   +0.15%     
==========================================
  Files          28       28              
  Lines        2385     2437      +52     
==========================================
+ Hits         2207     2259      +52     
  Misses        178      178              
Impacted Files Coverage Δ
ukat/mapping/t1.py 98.29% <100.00%> (ø)
ukat/mapping/tests/test_t2star.py 99.38% <0.00%> (+0.16%) ⬆️
ukat/mapping/t2star.py 94.96% <0.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 317ec9f...8179ea9. Read the comment docs.

@alexdaniel654 alexdaniel654 changed the title Added inline flake8 comments and removed pep8speaks Linting to GitHub Actions May 6, 2021
@alexdaniel654 alexdaniel654 marked this pull request as ready for review May 6, 2021 17:07
@JSousa-UoL
Copy link
Contributor

You can merge this yourself if you want to and when you're happy with this. I can see you've been testing this PEP8 feature on t1.py.

@alexdaniel654
Copy link
Member Author

It looks like I timed this one badly. I think GitHub have just changed something in their API as similar actions that have worked perfectly for years in other repos have not started failing. I'll come back to this in a few months when people have updated their actions to work with the changed API.

Pep8speak seems to be working so theres less of an urgent need for another linter now anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pep8-speaks to Actions linter
4 participants