adding variables

UKHomeOffice · Nov 13, 2024 · c9648b6 · c9648b6
1 parent fd072a8
commit c9648b6
Show file tree

Hide file tree

Showing 3 changed files with 57 additions and 38 deletions.
diff --git a/dynatrace_alerts.tf b/dynatrace_alerts.tf
@@ -4,16 +4,16 @@ resource "dynatrace_alerting" "my_alerting_profile" {
     filter {
       custom {
         description {
-          operator       = "CONTAINS"
-          value          = "CapacityUnits"
-          case_sensitive = true
-          enabled        = true
+          operator       = var.operator
+          value          = var.value
+          case_sensitive = var.case_sensitive
+          enabled        = var.enabled
         }
         title {
-          operator       = "CONTAINS"
-          value          = "CapacityUnits"
-          case_sensitive = true
-          enabled        = true
+          operator       = var.operator
+          value          = var.value
+          case_sensitive = var.case_sensitive
+          enabled        = var.enabled
 
         }
 
@@ -22,10 +22,10 @@ resource "dynatrace_alerting" "my_alerting_profile" {
   }
   rules {
     rule {
-      include_mode     = "INCLUDE_ALL"
-      tags             = ["test:test"]
-      delay_in_minutes = 1
-      severity_level   = "CUSTOM_ALERT"
+      include_mode     = var.include_mode
+      tags             = var.tags
+      delay_in_minutes = var.delay_in_minutes
+      severity_level   = var.severity_level
     }
   }
 }

diff --git a/dynatrace_metric_events.tf b/dynatrace_metric_events.tf
@@ -1,35 +1,35 @@
 # Creates a Dynatrace Management Zone
 resource "dynatrace_management_zone_v2" "Alerting_Test_MZ" {
-  name = "Alerting_Test_MZ"
+  name = var.management_zone_name
   rules {
     rule {
-      type            = "ME"
-      enabled         = true
-      entity_selector = ""
+      type            = var.rule_type
+      enabled         = var.enabled
+      entity_selector = var.entity_selector
       attribute_rule {
-        entity_type = "WEB_APPLICATION"
+        entity_type = var.entity_type
         attribute_conditions {
           condition {
-            case_sensitive = false
-            key            = "WEB_APPLICATION_NAME"
-            operator       = "CONTAINS"
-            string_value   = "test"
+            case_sensitive = var.case_sensitive
+            key            = var.key
+            operator       = var.operator
+            string_value   = var.string_value
           }
         }
       }
     }
     rule {
-      type            = "ME"
-      enabled         = true
-      entity_selector = ""
+      type            = var.rule_type
+      enabled         = var.enabled
+      entity_selector = var.entity_selector
       attribute_rule {
-        entity_type = "WEB_APPLICATION"
+        entity_type = var.entity_type
         attribute_conditions {
           condition {
             case_sensitive = true
-            key            = "WEB_APPLICATION_NAME"
-            operator       = "CONTAINS"
-            string_value   = "www.test.com"
+            key            = var.key
+            operator       = var.operator
+            string_value   = var.string_value
           }
         }
       }

diff --git a/variables.tf b/variables.tf
@@ -94,27 +94,46 @@ variable "slack_notification_enabled" {
 variable "slack_notification_name" {
   type = string
 }
-variable "elasticache_owner_name" {
+variable "operator" {
   type = string
 }
-variable "elasticache_shared" {
+variable "value" {
   type = string
 }
-variable "elasticache_dashboard_name" {
-  type = string
+variable "case_sensitive" {
+  type = bool
 }
-variable "elasticache_preset" {
+variable "enabled" {
   type = bool
 }
-variable "dynamodb_owner_name" {
+variable "include_mode" {
+  type = string
+}
+variable "tags" {
+  type = list(string)
+}
+
+variable "severity_level" {
   type = string
 }
-variable "dynamodb_shared" {
+variable "management_zone_name" {
   type = string
 }
-variable "dynamodb_dashboard_name" {
+variable "rule_type" {
   type = string
 }
-variable "dynamodb_preset" {
-  type = bool
+variable "entity_selector" {
+  type = string
+}
+variable "entity_type" {
+  type = string
+}
+variable "key" {
+  type = string
+}
+variable "string_value" {
+  type = string
+}
+variable "delay_in_minutes" {
+  type = string
 }