Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/fcdo2272/cabsv3 #159

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Feat/fcdo2272/cabsv3 #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fea4875
FCDO-2272: Prepare Configurable Forms for CABSv3
simonmoore100 Nov 26, 2024
6c226d7
Fix email formatting for Madesgar
simonmoore100 Nov 27, 2024
c642b3f
Remove additional docs for Madagascar
simonmoore100 Nov 28, 2024
a1ecf23
Remove requirement for Vietnam to provide proff of partner's birth ce…
simonmoore100 Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...es/services/UserService/personalisation/PersonalisationBuilder/marriage/inPerson/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ export function buildInPersonPersonalisation(answers: AnswersHashMap, metadata:
post: getPostForMarriage(country, post),
country,
bookingLink: additionalContext.bookingLink,
cabsV3BookingLink: additionalContext.bookingLink?.replace('www.book-consular-appointment.service.gov.uk/TimeSelection', 'www.manage-consular-appointment.service.gov.uk/s/appointment-booking'),
localRequirements: additionalContext.localRequirements ?? "",
civilPartnership: additionalContext.civilPartnership,
reference: metadata.reference,
Expand Down
11 changes: 5 additions & 6 deletions ...middlewares/services/UserService/personalisation/__tests__/PersonalisationBuilder.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ test("buildJobData should return the correct personalisation for an in-person em
expect(personalisation).toEqual({
firstName: "foo",
additionalDocs: "",
bookingLink: "https://www.book-consular-appointment.service.gov.uk/TimeSelection?location=67&service=13",
cabsV3BookingLink: "https://www.manage-consular-appointment.service.gov.uk/s/appointment-booking?location=67&service=13",
bookingLink: "https://www.manage-consular-appointment.service.gov.uk/s/appointment-booking?location=67&service=13",
civilPartnership: false,
country: "Turkey",
localRequirements: "",
Expand Down Expand Up @@ -92,7 +91,7 @@ test("getPostalAdditionalContext returns additionalContext correctly", () => {
"partner‘s proof any previous marriages or civil partnerships have ended ",
"proof of permanent address if you live outside of Italy",
],
bookingLink: "https://www.book-consular-appointment.service.gov.uk/TimeSelection?location=33&service=10",
bookingLink: "https://www.manage-consular-appointment.service.gov.uk/s/appointment-booking?location=33&service=10",
civilPartnership: true,
cniDelivery: true,
duration: "6 months",
Expand All @@ -106,7 +105,7 @@ test("getPostalAdditionalContext returns additionalContext correctly", () => {
additionalDocs: [
"a piece of paper with the Russian spelling of your full name as you want it to appear on your CNI (it needs to be consistent across all the documents you submit to the Russian authorities)",
],
bookingLink: "https://www.book-consular-appointment.service.gov.uk/TimeSelection?location=132&service=10",
bookingLink: "https://www.manage-consular-appointment.service.gov.uk/s/appointment-booking?location=132&service=10",
civilPartnership: false,
cniDelivery: false,
duration: "3 to 12 months (check with the person conducting your ceremony)",
Expand All @@ -118,7 +117,7 @@ test("getPostalAdditionalContext returns additionalContext correctly", () => {

expect(getPostalAdditionalContext("Poland", "cni")).toStrictEqual({
additionalDocs: "",
bookingLink: "https://www.book-consular-appointment.service.gov.uk/TimeSelection?location=40&service=10",
bookingLink: "https://www.manage-consular-appointment.service.gov.uk/s/appointment-booking?location=40&service=10",
civilPartnership: false,
cniDelivery: true,
duration: "6 months",
Expand Down Expand Up @@ -217,7 +216,7 @@ test("buildJobData should return the correct personalisation for a certify a cop
expect(personalisation).toEqual({
firstName: "test",
post: "the British Embassy Bangkok",
bookingLink: "https://www.book-consular-appointment.service.gov.uk/TimeSelection?location=53&service=9",
bookingLink: "https://www.manage-consular-appointment.service.gov.uk/s/appointment-booking?location=53&service=9",
reference: "1234",
});
});
Expand Down
Loading
Loading