Fix experimental-latest release making #738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! This actually seems to be caused by an issue with the release.py script related to it just grabbing the newest tag, so I'm testing a change there. |
|
The other fix worked. I'm debating if there's any other reason we may want to drop the "v" as it isn't really necessary. I guess having it did alert us to the tag issue sooner though. |
|
Closing for now because the bug was fixed in another location, may reopen if we decide to drop the v*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the tag
Type of change
How Has This Been Tested?
I haven't yet, Github Actions are very annoying, but the glob now matches the file name so it should just work