Skip to content

Commit

Permalink
Revert "Fixed dllexport for modules when not intending to export"
Browse files Browse the repository at this point in the history
This reverts commit e5469a2.
  • Loading branch information
UE4SS committed Oct 22, 2023
1 parent d336666 commit 0fc1401
Show file tree
Hide file tree
Showing 12 changed files with 12 additions and 23 deletions.
3 changes: 1 addition & 2 deletions deps/first/ASMHelper/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ endif ()
target_compile_features(${TARGET} PUBLIC cxx_std_20)

target_compile_definitions(${TARGET} PRIVATE
$<$<BOOL:${UE4SS_${TARGET}_BUILD_SHARED}>:
RC_${MODULE_NAME}_EXPORTS>
RC_${MODULE_NAME}_EXPORTS
$<$<NOT:$<BOOL:${UE4SS_${TARGET}_BUILD_SHARED}>>:
RC_${MODULE_NAME}_BUILD_STATIC>)

Expand Down
3 changes: 1 addition & 2 deletions deps/first/DynamicOutput/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ endif ()
target_compile_features(${TARGET} PUBLIC cxx_std_20)

target_compile_definitions(${TARGET} PRIVATE
$<$<BOOL:${UE4SS_${TARGET}_BUILD_SHARED}>:
RC_${MODULE_NAME}_EXPORTS>
RC_${MODULE_NAME}_EXPORTS
$<$<NOT:$<BOOL:${UE4SS_${TARGET}_BUILD_SHARED}>>:
RC_${MODULE_NAME}_BUILD_STATIC>)

Expand Down
3 changes: 1 addition & 2 deletions deps/first/File/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ endif ()
target_compile_features(${TARGET} PUBLIC cxx_std_20)

target_compile_definitions(${TARGET} PRIVATE
$<$<BOOL:${UE4SS_${TARGET}_BUILD_SHARED}>:
RC_${MODULE_NAME}_EXPORTS>
RC_${MODULE_NAME}_EXPORTS
$<$<NOT:$<BOOL:${UE4SS_${TARGET}_BUILD_SHARED}>>:
RC_${MODULE_NAME}_BUILD_STATIC>)

Expand Down
3 changes: 1 addition & 2 deletions deps/first/FunctionTimer/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ endif ()
target_compile_features(${TARGET} PUBLIC cxx_std_20)

target_compile_definitions(${TARGET} PRIVATE
$<$<BOOL:${UE4SS_${TARGET}_BUILD_SHARED}>:
RC_${MODULE_NAME}_EXPORTS>
RC_${MODULE_NAME}_EXPORTS
$<$<NOT:$<BOOL:${UE4SS_${TARGET}_BUILD_SHARED}>>:
RC_${MODULE_NAME}_BUILD_STATIC>)

Expand Down
3 changes: 1 addition & 2 deletions deps/first/IniParser/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ endif ()
target_compile_features(${TARGET} PUBLIC cxx_std_20)

target_compile_definitions(${TARGET} PRIVATE
$<$<BOOL:${UE4SS_${TARGET}_BUILD_SHARED}>:
RC_${MODULE_NAME}_EXPORTS>
RC_${MODULE_NAME}_EXPORTS
$<$<NOT:$<BOOL:${UE4SS_${TARGET}_BUILD_SHARED}>>:
RC_${MODULE_NAME}_BUILD_STATIC>)

Expand Down
3 changes: 1 addition & 2 deletions deps/first/Input/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ endif ()
target_compile_features(${TARGET} PUBLIC cxx_std_20)

target_compile_definitions(${TARGET} PRIVATE
$<$<BOOL:${UE4SS_${TARGET}_BUILD_SHARED}>:
RC_${MODULE_NAME}_EXPORTS>
RC_${MODULE_NAME}_EXPORTS
$<$<NOT:$<BOOL:${UE4SS_${TARGET}_BUILD_SHARED}>>:
RC_${MODULE_NAME}_BUILD_STATIC>)

Expand Down
3 changes: 1 addition & 2 deletions deps/first/JSON/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ endif ()
target_compile_features(${TARGET} PUBLIC cxx_std_20)

target_compile_definitions(${TARGET} PRIVATE
$<$<BOOL:${UE4SS_${TARGET}_BUILD_SHARED}>:
RC_${MODULE_NAME}_EXPORTS>
RC_${MODULE_NAME}_EXPORTS
$<$<NOT:$<BOOL:${UE4SS_${TARGET}_BUILD_SHARED}>>:
RC_${MODULE_NAME}_BUILD_STATIC>)

Expand Down
3 changes: 1 addition & 2 deletions deps/first/LuaMadeSimple/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ endif ()
target_compile_features(${TARGET} PUBLIC cxx_std_20)

target_compile_definitions(${TARGET} PRIVATE
$<$<BOOL:${UE4SS_${TARGET}_BUILD_SHARED}>:
RC_${MODULE_NAME}_EXPORTS>
RC_${MODULE_NAME}_EXPORTS
$<$<NOT:$<BOOL:${UE4SS_${TARGET}_BUILD_SHARED}>>:
RC_${MODULE_NAME}_BUILD_STATIC>)

Expand Down
3 changes: 1 addition & 2 deletions deps/first/LuaRaw/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,7 @@ endif ()
target_include_directories(${TARGET} PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/include)

target_compile_definitions(${TARGET} PRIVATE
$<$<BOOL:${UE4SS_${TARGET}_BUILD_SHARED}>:
RC_${MODULE_NAME}_EXPORTS>
RC_${MODULE_NAME}_EXPORTS
$<$<NOT:$<BOOL:${UE4SS_${TARGET}_BUILD_SHARED}>>:
RC_${MODULE_NAME}_BUILD_STATIC>)

Expand Down
3 changes: 1 addition & 2 deletions deps/first/ParserBase/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ endif ()
target_compile_features(${TARGET} PUBLIC cxx_std_20)

target_compile_definitions(${TARGET} PRIVATE
$<$<BOOL:${UE4SS_${TARGET}_BUILD_SHARED}>:
RC_${MODULE_NAME}_EXPORTS>
RC_${MODULE_NAME}_EXPORTS
$<$<NOT:$<BOOL:${UE4SS_${TARGET}_BUILD_SHARED}>>:
RC_${MODULE_NAME}_BUILD_STATIC>)

Expand Down
3 changes: 1 addition & 2 deletions deps/first/SinglePassSigScanner/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ endif ()
target_compile_features(${TARGET} PUBLIC cxx_std_20)

target_compile_definitions(${TARGET} PRIVATE
$<$<BOOL:${UE4SS_${TARGET}_BUILD_SHARED}>:
RC_${MODULE_NAME}_EXPORTS>
RC_${MODULE_NAME}_EXPORTS
$<$<NOT:$<BOOL:${UE4SS_${TARGET}_BUILD_SHARED}>>:
RC_${MODULE_NAME}_BUILD_STATIC>)

Expand Down
2 changes: 1 addition & 1 deletion deps/first/Unreal

0 comments on commit 0fc1401

Please sign in to comment.