Nested file support #226
Open
Nested file support #226
+121
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 10, 2025 18:57
Recursively searches nested folders for audio files to process. Extension and files to skip can be specified.
|
TODO: allow entire directories to be ignored instead of individual files |
ntlhui
reviewed
Jan 11, 2025
Comment on lines
+170
to
+172
| root_dir = os.path.abspath(root_dir) | ||
| audio_files = glob.glob(f"{root_dir}/**/*{extension}", recursive=True) | ||
| audio_files = [file for file in audio_files if file not in ignore] |
There was a problem hiding this comment.
I would also recommend using pathlib and/or rglob
Also consider whether lazy evaluation of the list evaluation is acceptable (use a generator)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.