-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend/theme] script for bootswatch theme compilation #931
base: master
Are you sure you want to change the base?
Changes from 1 commit
cce463f
2b535fc
252ccaa
6e58302
9ff71ff
aad5c64
d7831c9
dd7dacf
af0cee6
161d4a5
541c0cf
a0674f2
61ead04
fa24e8a
4f40a72
3cc8327
b8bcd6e
7408cb6
0f33120
1a1901c
98212de
e53e6c4
0991e81
d05168a
1cca275
c42d44f
fa501dd
408bc78
d37d234
93e301d
0b206d6
d601628
48ebcec
b6366da
5472789
94e47ff
6826dbd
f53b98f
dedbdbd
fb5adb1
218facb
b15462c
c2ce8c8
9a45e31
70691bc
9202efd
595680e
e771838
244004d
d879278
fde4fac
0533452
3f5a7bb
094de20
8e42845
567d98f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
BOOTSWATCH_URL = https://github.com/thomaspark/bootswatch.git | ||
BASE_THEME = yeti | ||
|
||
compile: | ||
if [ ! -d "bootswatch" ]; then make install; fi | ||
cd bootswatch; ./node_modules/grunt/bin/grunt swatch:$(theme) | ||
mv bootswatch/dist/$(theme)/bootstrap.css $(theme).css | ||
|
||
install: | ||
git clone $BOOTSWATCH_URL | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In this case we do not use a fixed version as discussed before. @nrybowski suggested to use a submodule to include the source at a given commit stage. We can probably add a Besides, as discussed previously, it would probably be better to store the source files for yeti and the modified yeti dark mode into our repository (keeping their copyright of course) and only keep a submodule to bootstrap. In all case we need to be able to rebuild the |
||
cd bootswatch | ||
npm install | ||
npm install grunt-cli | ||
|
||
help: | ||
echo "Usage : make theme={your_theme_name}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be more convenient if all these steps could be carried out by grunt to avoid adding development dependencies. In case the yeti sources are provided in our repo the build configuration file should be provided too and can be modified to place the file in the appropriate locations.