fix #368 check offsets after reflecting strands to ensure offsets are… #772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if test cases were necessary, but I added them. Though there are two problems with this:
The bug seems to be fixed, and running the test script passes all test cases, aside from having to spam "ok" and the warnings that appear.
I could not find a similar test case in which a window alert is involved, so I'm not sure how to go around this. And I'm quite lost on why the warnings appear.