Fixes #990 - Upgrade to Dart 3 #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some dependencies have been upgraded to work with dart 3. However, many of the tests still fail to run.
…ic crossover This reverts commit f827627312ac51f9afa45fc1d23d5e290fbde43d.
|
It should now be passing all tests. Please let me know if there are any other changes you require. |
dave-doty
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds support for Dart 3. However, there is some dependency overrides added to fix some issues. I have not yet found a way to solve this issue without adding the dependency override.
Furthermore, it is still failing
export_cadnano_v2_test.dart.Related Issue
Fixes #990
Motivation and Context
This is to hopefully solve the long build times, but most importantly place the repository on the current dart dependency. This brings everything up to date.
How Has This Been Tested?
This was tested on Windows 11, using Dart 3.5.4. The browsers I used were Firefox and Google Chrome. Since the JSONEncoder became a final class, we couldn't extend it anymore. We had to re-implement the JsonEncoder in our own way.