Skip to content
This repository has been archived by the owner on May 8, 2022. It is now read-only.

Add suggested changes #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add suggested changes #2

wants to merge 1 commit into from

Conversation

nikhilwoodruff
Copy link

This adds the suggestions from the review on #1 from @MaxGhenis .

tax_unit = pd.DataFrame(index=person.person_tax_unit_id.unique())
spm_unit = pd.DataFrame(index=person.person_spm_unit_id.unique())
tax_unit["tax_unit_id"] = tax_unit.index
spm_unit["spm_unit_id"] = spm_unit.index
tax_unit[
"tax_unit_weight"
] = 1e5 # not accurate, just a placeholder until development
spm_unit["spm_unit_weight"] = 1e5
spm_unit["spm_unit_weight"] = person.P_SPM_WEIGHT.groupby(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants