State Pivot Tables #130
Open
State Pivot Tables #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improvements to function for reading data from GitHub, use of new microdf groupby to simplify functions, pivot tables of state-based % changes in poverty and gini.
State Pivot Tables
|
Hello @jwal1024! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-01-22 01:45:56 UTC |
MaxGhenis
reviewed
Jan 21, 2021
There was a problem hiding this comment.
Some minor comments. Also it'd be good for this to do something that feeds into the broader analysis by exporting results for the notebook to load and display. It currently looks like it prints a couple dataframes but this would only be useful when viewing from terminal or copy/pasting elsewhere.
| raw = pd.read_csv( | ||
| "https://github.com/UBICenter/child-allowance/blob/master/jb/data/cps_00003.csv.gz", | ||
| person_raw = pd.read_csv( | ||
| "https://github.com/UBICenter/child-allowance/blob/master/jb/data/cps_00003.csv.gz?raw=true", # noqa |
There was a problem hiding this comment.
Load this locally (should also be able to skip compression="gzip" after doing so
MaxGhenis
reviewed
Jan 21, 2021
Removed demographic Ginis but retained state-based; removed pp_change function; removed special characters. Remaining: Deal with local load + compression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements to function for reading data from GitHub, use of new microdf groupby to simplify functions, pivot tables of state-based % changes in poverty and gini.