Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

centralized cache for CI workflow on the main branch #34

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

wenyunie
Copy link
Collaborator

I noticed that the CI check for the most recent two pull requests took very long and the cache mechanism did not seem to work. It turns out caches of workflows for different pull requests do not share. There needs to be a centralized cache on the default main branch to be shared across pull requests and child branches. This update is meant to add this. There should be a cache to be shared by all pull requests after a first workflow run is triggered by push to main and done on main.

image

Copy link
Collaborator

@monazhu monazhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for catching that! I did notice that it was taking longer than expected to run but wasn't putting 2 and 2 together 😅

@monazhu monazhu merged commit 3855b0e into main Nov 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants