-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #97 from UBC-MDS/74-changelogmd
Adding changelog.md [ready to be merged]
- Loading branch information
Showing
1 changed file
with
77 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| - updating the docker-compose.yml for clarification of platform for running the container | ||
| - feedback from: https://github.com/UBC-MDS/data-analysis-review-2023/issues/20#issuecomment-1841769787 | ||
| - recorded change: https://github.com/UBC-MDS/speed_dating_analysis/pull/75 | ||
|
|
||
| - providing Rosetta as the solution of M1/M2 chips in the readme file that could be the most convenient solution | ||
| - feedback from: https://github.com/UBC-MDS/data-analysis-review-2023/issues/20#issuecomment-1839718485 | ||
| - recorded change: https://github.com/UBC-MDS/speed_dating_analysis/pull/70 | ||
|
|
||
| - changing the phrasing of running cells to knit the file, which was confusing earlier | ||
| - feedback from: milestone 1 feedback | ||
| - <img width="332" alt="image" src="https://github.com/UBC-MDS/speed_dating_analysis/assets/143786716/f4562520-4d3d-43ee-94ee-094b7e7d9a86"> | ||
| - recorded change: https://github.com/UBC-MDS/speed_dating_analysis/pull/68 | ||
|
|
||
| - changing the readme file wording, we were given feedback we were not clear with how to open the project and activate renv | ||
| - feedback from: milestone 1 feedback | ||
| - <img width="327" alt="image" src="https://github.com/UBC-MDS/speed_dating_analysis/assets/143786716/52d094f0-1a9d-4c30-aaaf-2d5cf22c0054"> | ||
| - recorded change: https://github.com/UBC-MDS/speed_dating_analysis/pull/65 | ||
|
|
||
| - changing the readme file wording, we were given feedback we were not clear with how to open the project and activate renv | ||
| - feedback from: milestone 2 feedback | ||
| - <img width="303" alt="image" src="https://github.com/UBC-MDS/speed_dating_analysis/assets/143786716/87dddb92-56c3-4d45-8482-8409babae848"> | ||
| - <img width="317" alt="image" src="https://github.com/UBC-MDS/speed_dating_analysis/assets/143786716/9637add1-7109-4360-acbd-de1c2756c64f"> | ||
| - recorded change: https://github.com/UBC-MDS/speed_dating_analysis/pull/96 | ||
|
|
||
| - updated license: branch update_license | ||
| - commit [[ad3b4d8]](https://github.com/UBC-MDS/speed_dating_analysis/commit/ad3b4d8c97a3397d4ce083df57b2e731987a2bf4) | ||
| - from feedback https://github.com/UBC-MDS/data-analysis-review-2023/issues/20#issuecomment-1839718485 | ||
|
|
||
| - update dependencies: branch dependencies added to | ||
| - README [[f8eb546]](https://github.com/UBC-MDS/speed_dating_analysis/commit/f8eb546e1a3aaab5ff4d946ddd5c0ae9da64ce3c) | ||
| - (not mentioned in the feedback from anyone, we still did it) | ||
|
|
||
| - fix typo in CODE_OF_CONDUCT.md | ||
| - commit [[0c3eabb981aab76d4aedb3c17a617fab972a7c53]](https://github.com/UBC-MDS/speed_dating_analysis/commit/0c3eabb981aab76d4aedb3c17a617fab972a7c53) | ||
| - from feedback https://github.com/UBC-MDS/data-analysis-review-2023/issues/20#issuecomment-1841769787 | ||
|
|
||
| - fix link in CONTRIBUTING.md: | ||
| - commit [[250ec927c0ecf515f46625200d1bdfad9f89e391]](https://github.com/UBC-MDS/speed_dating_analysis/commit/250ec927c0ecf515f46625200d1bdfad9f89e391) and [[11bbb47bcd2a516f0ff278d9ccf0d0c897736adc]](https://github.com/UBC-MDS/speed_dating_analysis/commit/11bbb47bcd2a516f0ff278d9ccf0d0c897736adc) | ||
| - from feedback https://github.com/UBC-MDS/data-analysis-review-2023/issues/20#issuecomment-1841769787 | ||
|
|
||
| - Updated Readme with the makefile instructions | ||
| - commit: [[b84973d48c5455828457afa42a0138fa8e7b6630]](https://github.com/UBC-MDS/speed_dating_analysis/commit/b84973d48c5455828457afa42a0138fa8e7b6630) | ||
|
|
||
| - Removed unused references from README.md | ||
| - Feedback origin: https://github.com/UBC-MDS/data-analysis-review-2023/issues/20#issuecomment-1839914849 | ||
| - Commit link: https://github.com/UBC-MDS/speed_dating_analysis/commit/f319cab4059e934292e515ae9a66d8f09e0cbe7f | ||
|
|
||
| - Made README.md file more understandable by reordering sections, rewording explanations and moving non-essential material to developers notes | ||
| - Feedback origin: https://github.com/UBC-MDS/data-analysis-review-2023/issues/20#issuecomment-1839718485 | ||
| - Commit link: https://github.com/UBC-MDS/speed_dating_analysis/commit/a6a3c849877b423ed7244fe945675dd68ff9324a | ||
|
|
||
| - Added edge case for Pearson file | ||
| - Commit link: https://github.com/UBC-MDS/speed_dating_analysis/commit/ae060fd6cd1ba580616e59a38eb97d0275e7f32a | ||
| - Feedback origin: milestone feedback | ||
| - <img width="314" alt="Screenshot 2023-12-08 at 5 04 32 PM" src="https://github.com/UBC-MDS/speed_dating_analysis/assets/125914446/da48e0b4-0954-4408-b92f-ec600e2f896f"> | ||
|
|
||
| - Updated report to more explicitly mention the EDA we did for the analysis | ||
| - Feedback 1: https://github.com/UBC-MDS/data-analysis-review-2023/issues/20#issuecomment-1839914849 | ||
| - Feedback 2: https://github.com/UBC-MDS/data-analysis-review-2023/issues/20#issuecomment-1842028526 | ||
|
|
||
| - We have also now expanded on our motivation for conducting the test statistic and how it relates to our question of interest | ||
| - Feedback 1: https://github.com/UBC-MDS/data-analysis-review-2023/issues/20#issuecomment-1839718485 | ||
| - Feedback 2: https://github.com/UBC-MDS/data-analysis-review-2023/issues/20#issuecomment-1841769787 | ||
| - commit: https://github.com/UBC-MDS/speed_dating_analysis/commit/eb4fbd312dc4a6b5ec7ea79029b53c8c6016500a | ||
|
|
||
| - Updated data cleaning function and tests to account for edge cases, and updated the changes according to the milestone 2 feedback; also updated the roxygen documentation as param was missing | ||
| - commit: https://github.com/UBC-MDS/speed_dating_analysis/commit/21f2b3205b43c97c2d71d473c5c1ac4973eb0000 | ||
| - commit: https://github.com/UBC-MDS/speed_dating_analysis/commit/01d0b71dd20014e50830cd3b6186fee367e9ae4a | ||
| - feedback from milestone 2 gradescope | ||
| -  | ||
| -  | ||
|
|
||
| - Updated README's developer notes to include instructions for running tests | ||
| - commit: https://github.com/UBC-MDS/speed_dating_analysis/commit/ff94063e1dc9da955d0a937d3ef4a1f674a3ca52 | ||
| - feedback from gradescope | ||
| -  | ||
|
|