All monaco-vscode packages are peerDependencies

[kaisalmen]

This fixes #789 and is related to CodinGame/monaco-vscode-api#544

[kaisalmen]

@CGNonofr the approach works with npm, pnpm and yarn. I just tested it with the next-14 release.

[cdietrich]

is there a list of dependencies we need now to prodivde?

[kaisalmen]

@cdietrich no, there should be no change on your end needed, but if you have an incompatible monaco-vscode package it will now flag this during install. Depending on the default setting of the package manager the install will fail immediately (npm) or a warning is written (pnpm).

[kaisalmen]

@CGNonofr if you agree with this I will perform the final release of the packages (finally 😆) later today or tomorrow.

[cdietrich]

hmmm
i had to add more in order for it to work

   "dependencies": {
+    "@codingame/monaco-vscode-api": "~11.1.2",
+    "@codingame/monaco-vscode-configuration-service-override": "~11.1.2",
+    "@codingame/monaco-vscode-editor-api": "~11.1.2",
+    "@codingame/monaco-vscode-extensions-service-override": "~11.1.2",
     "@codingame/monaco-vscode-keybindings-service-override": "~11.1.2",
+    "@codingame/monaco-vscode-languages-service-override": "~11.1.2",
+    "@codingame/monaco-vscode-localization-service-override": "~11.1.2",
+    "@codingame/monaco-vscode-log-service-override": "~11.1.2",
+    "@codingame/monaco-vscode-model-service-override": "~11.1.2",
-    "monaco-editor-wrapper": "6.0.0-next.11",
-    "monaco-languageclient": "9.0.0-next.11",
-    "vscode-ws-jsonrpc": "^3.3.2"
+    "monaco-editor-wrapper": "6.0.0-next.14",
+    "monaco-languageclient": "9.0.0-next.14",
+    "vscode-ws-jsonrpc": "3.4.0-next.14"
   },

[kaisalmen]

@cdietrich this verification example https://github.com/TypeFox/monaco-languageclient/blob/issue-789/verify/peer/package.json will fail with npm

[CGNonofr]

👍

[kaisalmen]

i had to add more in order for it to work

@cdietrich which package manager?

[cdietrich]

we are using yarn.

with

  "dependencies": {
    "@codingame/monaco-vscode-keybindings-service-override": "~11.1.2",
    "monaco-editor-wrapper": "6.0.0-next.14",
    "monaco-languageclient": "9.0.0-next.14",
    "vscode-ws-jsonrpc": "3.4.0-next.14"
  },

yarn will complain about missing peers

but at runtime it will fail with e.g.

✘ [ERROR] Could not resolve "@codingame/monaco-vscode-languages-service-override"

    ../../node_modules/monaco-languageclient/lib/vscode/services.js:8:40:
      8 │ import getLanguagesServiceOverride from '@codingame/monaco-vscode-languages-service-override';

➤ YN0002: │ @xxx@workspace:docs/enduser doesn't provide @codingame/monaco-vscode-api (p45429), requested by monaco-languageclient.
➤ YN0002: │ @xxx@workspace:docs/enduser doesn't provide @codingame/monaco-vscode-configuration-service-override (pb2fb6), requested by monaco-languageclient.
➤ YN0002: │ @xxx@workspace:docs/enduser doesn't provide @codingame/monaco-vscode-editor-api (p399eb), requested by monaco-languageclient.
➤ YN0002: │ @xxx@workspace:docs/enduser doesn't provide @codingame/monaco-vscode-extensions-service-override (p96a48), requested by monaco-languageclient.
➤ YN0002: │ @xxx@workspace:docs/enduser doesn't provide @codingame/monaco-vscode-languages-service-override (p95f6a), requested by monaco-languageclient.
➤ YN0002: │ @xxx@workspace:docs/enduser doesn't provide @codingame/monaco-vscode-localization-service-override (pb558e), requested by monaco-languageclient.
➤ YN0002: │ @xxx@workspace:docs/enduser doesn't provide @codingame/monaco-vscode-log-service-override (p3731b), requested by monaco-languageclient.
➤ YN0002: │ @xxx@workspace:docs/enduser doesn't provide @codingame/monaco-vscode-model-service-override (p03ea4), requested by monaco-languageclient.

[cdietrich]

so i added all of these

[kaisalmen]

@cdietrich yes, yarn needs more (it used to be like that before) it does not automatically install required peers (npm and pnpm do). Had to do the same: https://github.com/TypeFox/monaco-languageclient/blob/main/verify/yarn/package.json

Even with latest yarn there is not argument available that allows to install peer dependencies directly. Don't ask me why.🤷‍♂️

[kaisalmen]

@CGNonofr figuring this out was time-consuming (more than I expected). I don't know how many times I installed packages today.

[kaisalmen]

@CGNonofr and @cdietrich new major versions are finally available:
https://www.npmjs.com/package/monaco-languageclient/v9.0.0
https://www.npmjs.com/package/vscode-ws-jsonrpc/v/3.4.0
https://www.npmjs.com/package/monaco-editor-wrapper/v/6.0.0
https://www.npmjs.com/package/@typefox/monaco-editor-react/v/6.0.0

[kaisalmen]

@CGNonofr one very important thing to note here. The peerDependencies work nicely with released packages available via npm. The enforcement does not work inside a npm workspace. I had a wrong devDependency defined in monaco-editor-wrapper and it did not lead to errors (see 12bcdf9). Fortunately it was only a devDependency and therefore did not require to updated the released version. Btw, that's also the reason why I released multiple next releases yesterday, because only then I was able to tell if an approach I tried had worked for real.