Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to vite 6 and drop webdriverio in favor of playwright #791

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Update to vite 6 and drop webdriverio in favor of playwright #791

merged 4 commits into from
Nov 29, 2024

Conversation

kaisalmen
Copy link
Collaborator

@kaisalmen kaisalmen commented Nov 28, 2024 •
edited
Loading

vitest debugging was anyhow only possible with playwright and now all test are stable locally and in the build pipeline.

@kaisalmen kaisalmen requested a review from CGNonofr as a code owner November 28, 2024 08:08
@kaisalmen
Copy link
Collaborator Author

@CGNonofr FYI your @codingame/esbuild-import-meta-url-plugin is still required. I tested it. Dev doesn't work properly without it.

@kaisalmen
Copy link
Collaborator Author

@CGNonofr are you around?

@kaisalmen
Copy link
Collaborator Author

FYI, I will go ahead an merge this,

@kaisalmen kaisalmen merged commit 5689ea4 into main Nov 29, 2024
1 check passed
@kaisalmen kaisalmen deleted the vite6 branch November 29, 2024 10:43
@CGNonofr
Copy link
Collaborator

CGNonofr commented Dec 2, 2024

Sorry, wasn't there #thanksgiving, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CGNonofr CGNonofr Awaiting requested review from CGNonofr CGNonofr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaisalmen @CGNonofr