Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to monaco-vscode-api 10.0.1 #761

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Updated to monaco-vscode-api 10.0.1 #761

merged 3 commits into from
Oct 10, 2024

Conversation

kaisalmen
Copy link
Collaborator

@kaisalmen kaisalmen commented Oct 9, 2024

Need to test this first tomorrow.

@CGNonofr I don't pass the htmlContainer to initialize if EditorService is used. If you have two monaco-editor like in the statemachine example you run into errors.

The other example fixes are independent of the new monaco-vscode-api version. These are just things I broke during recent changes.

@kaisalmen kaisalmen changed the title WIP: Updated to monaco-vscode-api 10.0.1 Updated to monaco-vscode-api 10.0.1 Oct 10, 2024
@kaisalmen kaisalmen marked this pull request as ready for review October 10, 2024 11:39
@kaisalmen kaisalmen requested a review from CGNonofr as a code owner October 10, 2024 11:39
@kaisalmen kaisalmen merged commit de5e0b2 into main Oct 10, 2024
2 checks passed
@kaisalmen kaisalmen deleted the mva-next branch October 10, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants