-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to monaco-vscode-api 3.2.1 #618
Conversation
What is the errors with the workers? |
@CGNonofr first, one guy called Kai is unable to type properly. Then vite gets confused if you specify this (js extension): typescript: () => new Worker(new URL('@codingame/monaco-vscode-standalone-typescript-language-features/worker.js', import.meta.url), { type: 'module' }) instead of this: typescript: () => new Worker(new URL('@codingame/monaco-vscode-standalone-typescript-language-features/worker', import.meta.url), { type: 'module' }) It is now working. |
Yep, that's because as soon as you have an So everything is fine now? |
It says the file is not there and that is just not true. It has no visibility due to the extra export. I like that you did that actually.
Yes |
- Disbale yarn verification in ci
@CGNonofr I disabled the yarn verification in the CI. It is making trouble all the time because it can't resolve local dependencies. |
…rors, set correct versions
@CGNonofr this is now really ready. |
Using the standalone packages from monaco-editor works. Transformation of workers to esm bundles also works fine. Loading the workers directly via the factory function does not. I don't understand yet why. Editor worker is no problem.