Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to @codingame/moanco-vscode-api version 2 #599

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Update to @codingame/moanco-vscode-api version 2 #599

merged 2 commits into from
Jan 29, 2024

Conversation

kaisalmen
Copy link
Collaborator

@kaisalmen kaisalmen commented Jan 26, 2024

Everythings works again expect for monaco-editor-workers have been removed. This will be fixed with upcoming merge of monaco-editor-wrapper and the example alignment.

It already uses @codingame/esbuild-import-meta-url-plugin
I aligned the lint configuration with other TypeFox projects (the delta is not huge).

I will fully update the README when all other work is completed.

@kaisalmen kaisalmen changed the title WIP: Update to @codingame/moanco-vscode-api version 2 Update to @codingame/moanco-vscode-api version 2 Jan 26, 2024
@kaisalmen kaisalmen marked this pull request as ready for review January 26, 2024 18:46
@kaisalmen kaisalmen requested a review from CGNonofr as a code owner January 26, 2024 18:46
@kaisalmen
Copy link
Collaborator Author

@CGNonofr I would like to continue the wrapper / example merge with this preview release and upgrade whenever there is something new.

@kaisalmen kaisalmen marked this pull request as draft January 29, 2024 09:32
@kaisalmen
Copy link
Collaborator Author

kaisalmen commented Jan 29, 2024

@CGNonofr I wait for the final versions of monaco-vscode-api and then let you know once it is ready

@kaisalmen
Copy link
Collaborator Author

@CGNonofr this is ready now. All doc updates will come later after the wrapper/example merge.

@kaisalmen kaisalmen marked this pull request as ready for review January 29, 2024 15:05
README.md Show resolved Hide resolved
packages/client/package.json Show resolved Hide resolved
@CGNonofr CGNonofr self-requested a review January 29, 2024 16:22
Copy link
Collaborator

@CGNonofr CGNonofr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then 👍

@kaisalmen kaisalmen merged commit 168dce8 into main Jan 29, 2024
2 checks passed
@kaisalmen kaisalmen deleted the mva-v2 branch January 29, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants