Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to @codingame/[email protected] #594

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Updated to @codingame/[email protected] #594

merged 3 commits into from
Jan 22, 2024

Conversation

kaisalmen
Copy link
Collaborator

@kaisalmen kaisalmen commented Jan 19, 2024

@CGNonofr initialize is broken. I checked your demo differences between 1.85.0 and 1.85.3 there was no code change required. It should just work with the newer version, right or did I miss something?
Version 1.85.4 fixes the issue.

The latest version 1.85.5 is now used. In addition this adds a docker-compose based wrapper for the new groovy language server. README is updated.

@CGNonofr
Copy link
Collaborator

Yes, you've approved the fix 2 hours ago!

I'll trigger a release

@kaisalmen
Copy link
Collaborator Author

@CGNonofr I should have checked the issue. It states the same problem. 🙈 Thank you!

@kaisalmen kaisalmen changed the title WIP: Updated to @codingame/[email protected] Updated to @codingame/[email protected] Jan 20, 2024
@kaisalmen kaisalmen marked this pull request as ready for review January 20, 2024 09:13
@kaisalmen kaisalmen requested a review from CGNonofr as a code owner January 20, 2024 09:13
@kaisalmen
Copy link
Collaborator Author

@CGNonofr this is ready now.

@kaisalmen kaisalmen changed the title Updated to @codingame/[email protected] Updated to @codingame/[email protected] Jan 22, 2024
Copy link
Collaborator

@CGNonofr CGNonofr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaisalmen
Copy link
Collaborator Author

@CGNonofr what do you think about the docker-compose approach for the groovy LS?

@CGNonofr
Copy link
Collaborator

@CGNonofr what do you think about the docker-compose approach for the groovy LS?

It's maybe a little overkill for a single container but hey at least it's easy to use and there's nothing to configure! (I haven't played with it yet though)

@kaisalmen kaisalmen merged commit b912f12 into main Jan 22, 2024
2 checks passed
@kaisalmen kaisalmen deleted the mva-next branch January 22, 2024 09:05
@kaisalmen
Copy link
Collaborator Author

and there's nothing to configure!

That is the point! 😎 The non-container way is described in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants