Updated to [email protected]

[kaisalmen]

Looking good apart from this:

It is called from inside monaco.js:

[CGNonofr]

Are you sure there is no duplicated package?

[kaisalmen]

Observation: Updating the overrides usually requires to nuke both package-lock.json and node_modules otherwise you get mismatching monaco-editor versions (e.g. 0.44.0 suddenly bleeding in again)

Are you sure there is no duplicated package?

At least not monaco-editor. I will check if there is something else wrong.

[CGNonofr]

I would be surprised there is that error here and not in monaco-vscode-api demo.

[kaisalmen]

It happens when I use getKeybindingsServiceOverride. If I comment that one the error is gone. Did I miss a change in that regard?

[CGNonofr]

It doesn't ring a bell to me

[kaisalmen]

It doesn't ring a bell to me

I haven't found a smoking gun either last night, but I also didn't search deeper. I wanted to verify in the demo and discovered CodinGame/monaco-vscode-api#259

[kaisalmen]

@CGNonofr monaco.js is imported from both packages:

The later one is called first and the second one then results in the error.

[CGNonofr]

well spotted! the issue was present as well in monaco-vscode-api but the window logs are not in the output view only and I didn't check it => CodinGame/monaco-vscode-api#261

[kaisalmen]

@CGNonofr Works fine now! Thank you. Will push an update soon.