Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to monaco-vscode-api 1.82.5 #549

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Update to monaco-vscode-api 1.82.5 #549

merged 4 commits into from
Oct 11, 2023

Conversation

kaisalmen
Copy link
Collaborator

@kaisalmen kaisalmen commented Oct 11, 2023

WIP: The server changes are not working as expected.

What the title says
In addition, I unified the language server usage. Less code to maintain.

I have the strange observation that the first code completion request from the JSON LS takes a long time, but afterwards works fine. I don't remember it used to be like this. 🤷‍♂️ Can you test this as well? Thanks.

Will update once CodinGame/monaco-vscode-api#206 is merged and final release is available.

@CGNonofr
Copy link
Collaborator

LGTM

@CGNonofr
Copy link
Collaborator

CGNonofr commented Oct 11, 2023

I have the strange observation that the first code completion request from the JSON LS takes a long time, but afterwards works fine. I don't remember it used to be like this. 🤷‍♂️ Can you test this as well? Thanks.

I have the same issue, the server doesn't answer to hover and completion requests before ~15s

@kaisalmen kaisalmen marked this pull request as ready for review October 11, 2023 18:03
@kaisalmen
Copy link
Collaborator Author

kaisalmen commented Oct 11, 2023

I have the same issue, the server doesn't answer to hover and completion requests before ~15s

This was my Don Quijote moment today. Fighting the windmill. I went back to 6.5.0 and had the same issues. What was definitely not the case two weeks ago.

@kaisalmen
Copy link
Collaborator Author

@CGNonofr Is vscode-json-languageservice phoning home or doing other internal BS? 💩
It now works without problem 🧐 I updated to the 1.82.5-next.0 but that code is not involved with the language server. This stinks a bit.

@kaisalmen
Copy link
Collaborator Author

Could it be linked to this? microsoft/vscode-json-languageservice#212

@kaisalmen kaisalmen merged commit 3a72b0c into main Oct 11, 2023
2 checks passed
@kaisalmen kaisalmen deleted the mva-1.82.5 branch October 11, 2023 19:27
@CGNonofr
Copy link
Collaborator

It's probably related to some downloading indeed, maybe the schema server was slow

@kaisalmen
Copy link
Collaborator Author

It's probably related to some downloading indeed, maybe the schema server was slow

Very likely the case. Timing was very bad. Because I thought I broke something last night / this morning.
Good thing is: The server start-up is now unified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants