-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to [email protected] and [email protected] #544
Conversation
ea70cda
to
1abe3de
Compare
- Update dependencies - Update volta version
5da5529
to
b7abbe8
Compare
@CGNonofr it is working nicely after I adapted the vite / experimental node config |
- Updated service dependencies - Updated repository urls
b7abbe8
to
5d44ed1
Compare
Next version is available: https://www.npmjs.com/package/monaco-languageclient/v/6.5.0-next.0 |
Wonderful! Don't you want me to wait for the monaco-vscode-api final release before approving it? |
Yes, I also want/force-me to update the README on this branch. 🙂 |
@CGNonofr updated to The README is basically ready. Should we remove the monaco-editor-core section from the troubleshooting section. This no longer relevant. WDYT? |
- Fixed exports - Examples: Removed unneeded views service dependency
7dfd235
to
7541471
Compare
@CGNonofr this is now ready to be merged. Further README clarification don't block this, I think. |
@CGNonofr I have not released a final version, because I discovered a nasty problem in |
@CGNonofr the problem is that sometimes the loading of extensions (e.g. themes) happens before and sometimes after. It seems that something that has been awaited before (1.81.x) and now not (1.82.x). Maybe something needs to be adjusted in |
Changes:
[email protected]
[email protected]
[email protected]
initServices
add both language and model service always and they are therefore a direct dependency ofmonaco-languageclient
. Without them using this lib doesn't really make sense.TODO:
@codingame/monaco-vscode-api
as soon as it released.