Skip to content

Commit

Permalink
Clean-up and CHANGELOG clarifications
Browse files Browse the repository at this point in the history
  • Loading branch information
kaisalmen committed Sep 29, 2023
1 parent 9569210 commit bfd64fa
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion packages/client/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ All notable changes to this npm module are documented in this file.
## [6.5.0] - 2023-09-29

- Updated to `monaco-editor` `0.43.0` and `monaco-vscode-api` `1.82.2`
- Only keep user services in`initServices`. It requires to specifically import and use services provided by [monaco-vscode-api](https://github.com/CodinGame/monaco-vscode-api#monaco-standalone-services)
- Only keep user services in`initServices`. It requires to specifically import and use services provided by [monaco-vscode-api](https://github.com/CodinGame/monaco-vscode-api#monaco-standalone-services)
- All *enable...* and *configure* type parameters have been removed from `monaco-languagclient`
- languages and model services are always added by `monaco-languagclient`
- layout, environment, extension, files and quickAccess servies are always added by `monaco-vscode-api`
- Additional services need to be added to the package dependencies and imported and configured as shown in the [examples](https://github.com/TypeFox/monaco-languageclient#examples)
Expand Down
3 changes: 2 additions & 1 deletion packages/examples/src/common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ export const createLanguageClient = (transports: MessageTransports): MonacoLangu
}
});
};

export const createUrl = (hostname: string, port: number, path: string, searchParams: Record<string, any> = {}, secure: boolean = location.protocol === 'https:'): string => {
const protocol = secure ? 'wss' : 'ws';
const url = new URL(`${protocol}://${hostname}:${port}${path}`);
Expand Down Expand Up @@ -89,7 +90,7 @@ export const performInit = async (vscodeApiInit: boolean) => {
...getThemeServiceOverride(),
...getTextmateServiceOverride(),
...getConfigurationServiceOverride(Uri.file('/workspace')),
...getKeybindingsServiceOverride(),
...getKeybindingsServiceOverride()
},
debugLogging: true
});
Expand Down
1 change: 0 additions & 1 deletion packages/verify/webpack/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { fileURLToPath } from 'url';
import { dirname, resolve } from 'path';
const __filename = fileURLToPath(import.meta.url);
const __dirname = dirname(__filename);
const projectRoot = resolve(__dirname, '../../..');

const config = {
entry: resolve(__dirname, 'src', 'client', 'main.ts'),
Expand Down

0 comments on commit bfd64fa

Please sign in to comment.