README: Clarify vite dedupe usage

TypeFox · Oct 4, 2023 · 329680f · 329680f
1 parent 08c1a93
commit 329680f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -249,7 +249,7 @@ There are [Volta](https://volta.sh/) instructions in the `package.json` files. W
 
 When you are using vite for development please be aware of [this recommendation](https://github.com/CodinGame/monaco-vscode-api#if-you-use-vite).
 
-Since version `1.82.0` of `@codingame/monaco-vscode-api` you need to add this your vite configuration:
+If you see the problem *Assertion failed (There is already an extension with this id)* you likely have mismatching dependencies defined for `monaco-editor` or `@codingame/monaco-vscode-api`. You should fix this or add the following entry to your vite config:
 
 ```javascript
 resolve: {

diff --git a/vite.config.ts b/vite.config.ts
@@ -19,7 +19,8 @@ export default defineConfig(() => {
             }
         },
         resolve: {
-            dedupe: ['monaco-editor', 'vscode']
+            // not needed here, see https://github.com/TypeFox/monaco-languageclient#vite-dev-server-troubleshooting
+            // dedupe: ['monaco-editor', 'vscode']
         },
         server: {
             origin: 'http://localhost:8080',