Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left sidebar arrows Update #5627

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Arturas-Salivonas
Copy link
Collaborator

@Arturas-Salivonas Arturas-Salivonas commented Oct 18, 2024

https://deploy-preview-5627--tyk-docs.netlify.app/docs/nightly

Left sidebar arrows Update

For internal users - Please add a Jira DX PR ticket to the subject!



Preview Link


Description

  1. Arrows on the left sidebar moved to the Right side.

  2. Updated left sidebar arrow logic.
    Closed state: Arrows point to the Right.
    Open state: Arrows point to the bottom.

  3. Updated spacing(padding) in the left sidebar.


Screenshots (if appropriate)


Checklist

  • I have added a preview link to the PR description.
  • I have reviewed the suggestions made by our AI (PR Agent) and updated them accordingly (spelling errors, rephrasing, etc.)
  • I have reviewed the guidelines for contributing to this repository.
  • I have read the technical guidelines for contributing to this repository.
  • Make sure you have started your change off our latest master.
  • I labeled the PR

Copy link

netlify bot commented Oct 18, 2024

👷 Deploy request for tyk-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 4cf1944

Copy link
Contributor

@sharadregoti sharadregoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also incorporate the following changes

  1. Currently the arrow pointing in the right direction is not aligned with the center of the starting text. Can we align it horizontally
  2. Reduce the spacing between the arrow and the starting of text by 4 to 8 pixels

tyk-docs/assets/scss/_side-menu.scss Outdated Show resolved Hide resolved
@yurisasuke yurisasuke removed their request for review November 22, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants