Fix-#v-2.1.11 #80
Fix-#v-2.1.11 #80
Conversation
Fix-#v-2.1.11 version change PR.
There was a problem hiding this comment.
Code analysis identified issues
Tyche Softwares has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.
phpcs scanning turned up:
🚫 4 errors
Powered by Tyche Softwares
| return; | ||
| if ( is_user_logged_in() && current_user_can( 'manage_options' ) && wp_verify_nonce( $nonce, 'tracking_notice' ) ) { | ||
| update_option( self::$plugin_prefix . '_allow_tracking', 'dismissed' ); | ||
| Shortcodes_TS_Tracker::ts_send_tracking_data( false ); |
There was a problem hiding this comment.
🚫 Error: Tabs must be used to indent lines; spaces are not allowed (Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed).
| if ( is_user_logged_in() && current_user_can( 'manage_options' ) && wp_verify_nonce( $nonce, 'tracking_notice' ) ) { | ||
| update_option( self::$plugin_prefix . '_allow_tracking', 'dismissed' ); | ||
| Shortcodes_TS_Tracker::ts_send_tracking_data( false ); | ||
| die(); |
There was a problem hiding this comment.
🚫 Error: Tabs must be used to indent lines; spaces are not allowed (Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed).
plugin.php
Outdated
| @@ -27,7 +27,7 @@ class Arconix_Shortcodes { | |||
| * @access private | |||
| * @var string $version Current plugin version | |||
| */ | |||
| const VERSION = '2.1.10'; | |||
| const VERSION = '2.1.11'; | |||
There was a problem hiding this comment.
🚫 Error: Tabs must be used to indent lines; spaces are not allowed (Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed).
plugin.php
Outdated
| @@ -27,7 +27,7 @@ | |||
| * @access private | |||
| * @var string $version Current plugin version | |||
| */ | |||
| const VERSION = '2.1.10'; | |||
| const VERSION = '2.1.11'; | |||
There was a problem hiding this comment.
🚫 Error: Whitespace found at end of line (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine).
Fix-#v-2.1.11 fix phpcs errors.
There was a problem hiding this comment.
Code analysis identified issues
Tyche Softwares has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.
phpcs scanning turned up:
🚫 1 error
Powered by Tyche Softwares
| @@ -27,7 +27,7 @@ class Arconix_Shortcodes { | |||
| * @access private | |||
| * @var string $version Current plugin version | |||
| */ | |||
| const VERSION = '2.1.10'; | |||
| const VERSION = '2.1.11'; | |||
There was a problem hiding this comment.
🚫 Error: Tabs must be used to indent lines; spaces are not allowed (Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed).
tyche-bot
dismissed
their stale review
Dismissing review as all inline comments are obsolete by now
Fix #v-2.1.11 version change PR.
Dismissing Notices - Implementing nonce check as well as permission/role based on this security report: This Patchstack report
Added the user to be logged in and permission check and nonce before the action can be executed.