Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brandonnoard/eslint #266

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Brandonnoard/eslint #266

wants to merge 3 commits into from

Conversation

brandonnoard
Copy link
Contributor

What

Brief description of changes.

Add linting to the sources.

Why

Ensure that the code uses a similar style throughout.

Ensure the following interactions work as expected. Please test using a mobile form factor.

  • Tapping on a marker on the map displays information about the marker in a popup.
  • Tapping the "Show list of locations" button replaces the map view with a list view. Don't see this in the UI, list is always on the left
  • Tapping an item in the list replaces the list view with a map view, and navigates the map to the tapped item on the map. Using existing list view
  • Tapping one of the ✅'s in the legend filters items on the map and in the list.
  • Changing the language to spanish changes things on the page.
  • Clicking the Help/Info button opens and closes a menu with information.
  • Clicking the X Close button on the Help/Info screen closes the modal.

Check the app in the following web browsers:

  • Chrome
  • Firefox
  • Edge
  • Safari

`gtag` and `List` are taken care of in the `index.html` page, so
assume that they are always present.
Copy link
Contributor

@amaxama amaxama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just needs master merge! I honestly don't know a ton about eslint, but you said this config is a pretty standard set, right?
And this didn't bring up any lint errors in the code? I'm kinda surprised by that!

@kanadgupta kanadgupta mentioned this pull request May 2, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants