Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rails 6.0 support #5

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

zoommix
Copy link

@zoommix zoommix commented Nov 1, 2020

@voltechs
Copy link
Member

voltechs commented Dec 9, 2020

Hi @zoommix, thanks for the PR! This won't pass specs without the corresponding gemfiles/activerecord-6.0.Gemfile file as well.

@zoommix
Copy link
Author

zoommix commented Dec 26, 2020

Hi @voltechs.
My bad, thanks for the catch! The pr is updated.

@MauricioMoraes
Copy link

👍 for the merge!

@MauricioMoraes
Copy link

MauricioMoraes commented Feb 21, 2021

Obs: The "pry" gem is required for this PR to work. It should be declared in the dependencies

@zoommix
Copy link
Author

zoommix commented Mar 1, 2021

Obs: The "pry" gem is required for this PR to work. It should be declared in the dependencies

@MauricioMoraes
Isn't dependency declared in quick_count.gemspec enough?
We only need it on development so no need to add pry to activerecord-6.0.Gemfile.
bundle install successfully installed pry on my local machine.
Please correct me if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants