Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for EvoTrees to 0.16 for package test, (keep existing compat) #93

Merged
merged 10 commits into from
Oct 6, 2023
Merged

CompatHelper: bump compat for EvoTrees to 0.16 for package test, (keep existing compat) #93

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7024765
CompatHelper: bump compat for EvoTrees to 0.16 for package test, (kee…
Aug 13, 2023
e06947f
Merge branch 'main' into compathelper/new_version/2023-08-13-00-09-11…
sethaxen Oct 4, 2023
bd54d95
Merge branch 'main' into compathelper/new_version/2023-08-13-00-09-11…
sethaxen Oct 4, 2023
9d18cc0
Decrease learning rates
sethaxen Oct 4, 2023
3f13d93
Increase patch number
sethaxen Oct 4, 2023
3b2974e
Merge branch 'main' into compathelper/new_version/2023-08-13-00-09-11…
sethaxen Oct 5, 2023
0e6fecf
Revert "Decrease learning rates"
sethaxen Oct 5, 2023
58e6625
Increase tolerance of check
sethaxen Oct 5, 2023
93c770d
Merge branch 'main' into compathelper/new_version/2023-08-13-00-09-11…
sethaxen Oct 5, 2023
1a27af9
Merge branch 'main' into compathelper/new_version/2023-08-13-00-09-11…
sethaxen Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "MCMCDiagnosticTools"
uuid = "be115224-59cd-429b-ad48-344e309966f0"
authors = ["David Widmann"]
version = "0.3.6"
version = "0.3.7"

[deps]
AbstractFFTs = "621f4979-c628-5d54-868e-fcf4e3e8185c"
Expand Down
2 changes: 1 addition & 1 deletion test/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
Aqua = "0.6.5, 0.7"
Distributions = "0.25"
DynamicHMC = "3"
EvoTrees = "0.14.7, 0.15"
EvoTrees = "0.14.7, 0.15, 0.16"
FFTW = "1.1"
LogDensityProblems = "0.12, 1, 2"
LogExpFunctions = "0.3"
Expand Down
4 changes: 2 additions & 2 deletions test/rstar.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ end
@testset "samples input type: $wrapper" for wrapper in [Vector, Array, Tables.table]
# In practice, probably you want to use EvoTreeClassifier with early stopping
classifiers = (
EvoTreeClassifier(; nrounds=1_000, eta=0.1),
Pipeline(EvoTreeClassifier(; nrounds=1_000, eta=0.1); operation=predict_mode),
EvoTreeClassifier(; nrounds=1_000, eta=0.01),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it clear from the changelog why the parameters have to be changed? Or was the previous choice non-standard?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not from the changelog, but the failures seem to come from Evovest/EvoTrees.jl#250 changing defaults from (max_depth = 5, nbins=32) to (max_depth=6, nbins=64). Reverting either of these to the former default causes the tests to pass again.

Looks like a lot of parameter combinations cause the tests to pass, but just barely. Perhaps a better approach is to increase the rtol.

Pipeline(EvoTreeClassifier(; nrounds=1_000, eta=0.01); operation=predict_mode),
DecisionTreeClassifier(),
SVC(),
XGBoostClassifiers...,
Expand Down