Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make basic general plugin framework #34

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make basic general plugin framework #34

wants to merge 2 commits into from

Conversation

SGauvin
Copy link
Contributor

@SGauvin SGauvin commented Jun 24, 2024

  • Create a UI plugin that shows a processed audio spectrum
  • Add stuff to the AudioApi

@SGauvin SGauvin requested a review from samichoulo911 June 24, 2024 00:08
samichoulo911
samichoulo911 reviewed Jun 24, 2024
View reviewed changes
turbo_audio/src/plugins/audio_api.rs
) -> std::ffi::c_float {
let fft_result = unsafe { &*(instance as *const Arc<RwLock<FftResult>>) };
fft_result
.read()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should never block right? Since we only write to this when updating the FFT result (which is made before we tick plugins). Or is there something I am missing? If this does lock it would also lock the core loop right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samichoulo911 samichoulo911 samichoulo911 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SGauvin @samichoulo911