Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lua plugins rework #29

Merged
merged 14 commits into from
Nov 24, 2023
Merged

Lua plugins rework #29

merged 14 commits into from
Nov 24, 2023

Conversation

SGauvin
Copy link
Contributor

@SGauvin SGauvin commented Nov 23, 2023

  • Rework folder organization
  • Now turbo_audio (the rust code) is in its own folder, alongside the "effects" folder
  • The lua effects are in the "effects/lua" folder.
  • Rework some cancer that we had
  • Add a field in the config file to point to the lua folder
  • Add support appending to the package.path (http://www.lua.org/manual/5.1/manual.html#pdf-package.path) variable in lua so that lua effects can require("path.to.lualib") from any desired directory. This means that the lua libraries we provide could live somewhere else than the lua effects seamlessly.
  • Sets up the folder organization for putting an "effects/rust" folder where all the other effects will live
    • This is a good thing because LSPs are shitting their pants when you have a rust project inside another rust project
  • Format the json settings file
  • Use impl AsRef<Path> as parameters instead of &Path because it's better. (https://doc.rust-lang.org/rust-by-example/trait/impl_trait.html)
  • Update some crates
  • Remove jack option because it adds a dev dependency and I CBA

@SGauvin
Copy link
Contributor Author

SGauvin commented Nov 23, 2023

@samichoulo911

@SGauvin SGauvin merged commit f9174ae into main Nov 24, 2023
0 of 4 checks passed
@SGauvin SGauvin deleted the lua_rework branch November 24, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant