chore(deps): bump crate-ci/typos from 1.26.8 to 1.28.3 #265
clippy
9 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 9 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.84.0-beta.4 (202008a1b 2024-12-07)
- cargo 1.84.0-beta.4 (66221abde 2024-11-19)
- clippy 0.1.84 (202008a1b8 2024-12-07)
Annotations
Check warning on line 130 in src/indexable/dataloader/builder.rs
github-actions / clippy
`if let` assigns a shorter lifetime since Edition 2024
warning: `if let` assigns a shorter lifetime since Edition 2024
--> src/indexable/dataloader/builder.rs:130:12
|
130 | if let Some(pool) = THREAD_POOL.get() {
| ^^^^^^^^^^^^^^^^^-----------^^^^^^
| |
| this value has a significant drop implementation which may observe a major change in drop order and requires your discretion
|
= warning: this changes meaning in Rust 2024
= note: for more information, see issue #124085 <https://github.com/rust-lang/rust/issues/124085>
help: the value is now dropped here in Edition 2024
--> src/indexable/dataloader/builder.rs:144:9
|
144 | } else {
| ^
= note: `-W if-let-rescope` implied by `-W rust-2024-compatibility`
= help: to override `-W rust-2024-compatibility` add `#[allow(if_let_rescope)]`
help: a `match` with a single arm can preserve the drop order up to Edition 2021
|
130 ~ match THREAD_POOL.get() { Some(pool) => {
131 | if pool.current_num_threads() != self.num_threads {
...
143 | }
144 ~ } _ => {
145 | THREAD_POOL
...
152 | .ok();
153 ~ }}
|
Check warning on line 166 in src/iterable/dataloader.rs
github-actions / clippy
the following explicit lifetimes could be elided: 'dataset
warning: the following explicit lifetimes could be elided: 'dataset
--> src/iterable/dataloader.rs:166:6
|
166 | impl<'dataset, D, C> Iterator for Iter<'dataset, D, C>
| ^^^^^^^^ ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
166 - impl<'dataset, D, C> Iterator for Iter<'dataset, D, C>
166 + impl<D, C> Iterator for Iter<'_, D, C>
|
Check warning on line 42 in src/indexable/fetch.rs
github-actions / clippy
the following explicit lifetimes could be elided: 'dataset
warning: the following explicit lifetimes could be elided: 'dataset
--> src/indexable/fetch.rs:42:6
|
42 | impl<'dataset, D, C> Fetcher<D, C> for MapDatasetFetcher<'dataset, D, C>
| ^^^^^^^^ ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
42 - impl<'dataset, D, C> Fetcher<D, C> for MapDatasetFetcher<'dataset, D, C>
42 + impl<D, C> Fetcher<D, C> for MapDatasetFetcher<'_, D, C>
|
Check warning on line 157 in src/indexable/dataloader.rs
github-actions / clippy
the following explicit lifetimes could be elided: 'dataset
warning: the following explicit lifetimes could be elided: 'dataset
--> src/indexable/dataloader.rs:157:6
|
157 | impl<'dataset, D, S, C> ExactSizeIterator for SingleProcessDataLoaderIter<'dataset, D, S, C>
| ^^^^^^^^ ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
157 - impl<'dataset, D, S, C> ExactSizeIterator for SingleProcessDataLoaderIter<'dataset, D, S, C>
157 + impl<D, S, C> ExactSizeIterator for SingleProcessDataLoaderIter<'_, D, S, C>
|
Check warning on line 119 in src/indexable/dataloader.rs
github-actions / clippy
the following explicit lifetimes could be elided: 'dataset
warning: the following explicit lifetimes could be elided: 'dataset
--> src/indexable/dataloader.rs:119:6
|
119 | impl<'dataset, D, S, C> Iterator for SingleProcessDataLoaderIter<'dataset, D, S, C>
| ^^^^^^^^ ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
119 - impl<'dataset, D, S, C> Iterator for SingleProcessDataLoaderIter<'dataset, D, S, C>
119 + impl<D, S, C> Iterator for SingleProcessDataLoaderIter<'_, D, S, C>
|
Check warning on line 89 in src/indexable/dataloader.rs
github-actions / clippy
the following explicit lifetimes could be elided: 'dataset
warning: the following explicit lifetimes could be elided: 'dataset
--> src/indexable/dataloader.rs:89:6
|
89 | impl<'dataset, D, S, C> SingleProcessDataLoaderIter<'dataset, D, S, C>
| ^^^^^^^^ ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `-W clippy::needless-lifetimes` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::needless_lifetimes)]`
help: elide the lifetimes
|
89 - impl<'dataset, D, S, C> SingleProcessDataLoaderIter<'dataset, D, S, C>
89 + impl<D, S, C> SingleProcessDataLoaderIter<'_, D, S, C>
|
Check warning on line 10 in src/collate/default_collate/nonzero.rs
github-actions / clippy
empty line after doc comment
warning: empty line after doc comment
--> src/collate/default_collate/nonzero.rs:9:1
|
9 | / /// Maybe this one may not be supported by a tensor running on a GPU.
10 | |
| |_^
11 | macro_rules! nonzero_impl {
| ------------------------- the comment documents this macro
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= note: `-W clippy::empty-line-after-doc-comments` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::empty_line_after_doc_comments)]`
= help: if the empty line is unintentional remove it
Check warning on line 41 in src/indexable/dataset.rs
github-actions / clippy
trait `FunctorDataset` is never used
warning: trait `FunctorDataset` is never used
--> src/indexable/dataset.rs:41:7
|
41 | trait FunctorDataset<F>: Len + GetSample
| ^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 155 in src/iterable/dataloader.rs
github-actions / clippy
elided lifetime has a name
warning: elided lifetime has a name
--> src/iterable/dataloader.rs:155:41
|
147 | impl<'dataset, D, C> DataLoader<D, C>
| -------- lifetime `'dataset` declared here
...
155 | pub fn iter(&'dataset self) -> Iter<'_, <&'dataset D as IntoIterator>::IntoIter, C> {
| ^^ this elided lifetime gets resolved as `'dataset`
|
= note: `#[warn(elided_named_lifetimes)]` on by default