-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to override settings via config #22068
base: main
Are you sure you want to change the base?
Added ability to override settings via config #22068
Conversation
…errides to specific tests
- We need to return the entire object from getAll, not just the value. The override should only affect the value, not the entire object.
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
High level approach here is to override the Only the |
ref https://linear.app/ghost/issue/ENG-1974/create-config-option-to-forcibly-disable-email-track-clicks
email_track_clicks
setting forcibly via config, such that it is turned off and the user is unable to change it in the UI.settingsOverrides
object into the settings cache, which is passed in from thehostSettings:settingsOverride
configuration key, and overrides bothsettingsCache.get()
andsettingsCache.getAll()
to override the value of the setting that's returned with whatever is defined via configuration.