Reverted previous commit and fixed broken test instead

TryGhost · Jan 29, 2025 · 5fb65f0 · 5fb65f0
1 parent 3b9de85
commit 5fb65f0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/ghost/core/core/shared/settings-cache/CacheManager.js b/ghost/core/core/shared/settings-cache/CacheManager.js
@@ -69,8 +69,7 @@ class CacheManager {
             cacheEntry.override = true;
         }
 
-        // Return if the cacheEntry is undefined, but continue if it's null or false
-        if (cacheEntry === undefined) {
+        if (!cacheEntry) {
             return;
         }
 

diff --git a/ghost/core/test/e2e-api/admin/members.test.js b/ghost/core/test/e2e-api/admin/members.test.js
@@ -968,7 +968,7 @@ describe('Members API', function () {
         await agent.delete(`/members/${memberFailVerification.id}`);
 
         await configUtils.restore();
-        settingsCache.set('email_verification_required', false);
+        settingsCache.set('email_verification_required', {value: false});
     });
 
     it('Can add and send a signup confirmation email', async function () {