Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cddl latest (>=0.10.6) #36

Merged
merged 1 commit into from
Feb 22, 2024
Merged

use cddl latest (>=0.10.6) #36

merged 1 commit into from
Feb 22, 2024

Conversation

thomas-fossati
Copy link
Member

No description provided.

Copy link
Collaborator

@nedmsmith nedmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how the proposed change 'fixes' the issue.

run: |
gem install --user-install cbor-diag
gem install --user-install cddl -v 0.10.3
run: gem install --user-install cbor-diag cddl
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This puts it back to its original form which wouldn't catch the case where 0.10.6 wasn't installed.

Suggested change
run: gem install --user-install cbor-diag cddl
run: |
gem install --user-install cbor-diag
gem install --user-install cddl -v 0.10.6

Copy link
Member Author

@thomas-fossati thomas-fossati Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this CI workflow will be invoked from now onwards. Since Carsten has released 0.10.6 this will always pull at least v0.10.6.

This is inline with the local setting reflected in the Gemfile (i.e., >=0.10.6).

Copy link
Collaborator

@nedmsmith nedmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomas-fossati thomas-fossati merged commit c44669e into main Feb 22, 2024
1 check passed
@thomas-fossati thomas-fossati deleted the ci-tweak branch February 22, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants