Fix build errors #34
Fix build errors #34
Conversation
Invoking corim make from top level to pick up Gemfile environment
updated submodule
To avoid build errors where flags-map cddl requires an older version of cddl and more work is needed to get Gemfiles to work.
nedmsmith
requested review from
thomas-fossati,
DMattoon,
henkbirkholz and
yogeshbdeshpande
added Gemfile.lock to gitignore
Gemfile that corim uses to make flags-map examples.
added example diag file back
added .ruby-version to gitignore
There was a problem hiding this comment.
I "think" what you should do in this (submoduled) context is to modify your CI setup (.github/workflows/makefile.yml) to install cddl at a version prior to 0.10.5, i.e., something like:
gem --user-install install cddl -v 0.10.3
gem --user-install install cbor-diag
Yep, that was it. See #35 |
|
Given cddl v0.10.6 is available and can handle cddl2-isms, should this be changed to 0.10.6? |
Added install of a particular version 0.10.6 of cddl to yaml workflow
Added v 0.10.6 as an acceptable cddl version
added |
examples/fix-comid-flags.diag
Outdated
There was a problem hiding this comment.
why do we need this? Isn't it already in CoRIM's test suite?
There was a problem hiding this comment.
It tests the evidence representation (which borrows from corim). I think, the corim didn't test exhaustively the flags.
There was a problem hiding this comment.
However, this is a debugging file that shouldn't have been included in the PR. The file comid-flags.diag is the expected one.
Co-authored-by: Thomas Fossati <[email protected]>
Co-authored-by: Thomas Fossati <[email protected]>
remove temprary file
changed gitmodules to merge rather than rebase
Corim submodule fails to build flags-map example due to cddl command version differences. Moved failing example until a better fix can be found.