import fix for some helpers and steps #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EliChin
requested review from
vdomnich-yadro,
dansingjulia and
yadro-vavdeev
as code owners
alexchetaev
suggested changes
Mar 1, 2023
pytest_tests/steps/s3_gate_base.py
Outdated
| import urllib3 | ||
| from botocore.config import Config | ||
| from botocore.exceptions import ClientError | ||
| from frostfs_testlib.shell import Shell | ||
| from pytest import FixtureRequest | ||
|
|
||
| import pytest_tests.steps.s3_gate_bucket |
There was a problem hiding this comment.
I would suggest maintaining a single style: from ... import ....
from pytest_tests.steps import s3_gate_bucket
Signed-off-by: Liza <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some imports were not full and resulted in run failures (at least, in VSCode).