Update syn to 2.0, clean up error handling, add closure support to #[with(..)] in derive. #343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates syn version to 2.0, adds span reporting for some derive errors, and adds closure support for #[with(..)].
Bevy uses syn 2.0 as well, so once the derive-getters dependency is updated to a version that uses syn 2.0 as well, users won't need to compile both syn 1.0 and 2.0 libraries.
I also changed a few functions to return errors instead of panicking so users get span information for some errors. (I might do another pass in the future to add error messages to all derive errors)
I also added closure support for the #[with(..)] attribute. Example below:
Previously, you'd have to make a separate function for every field you want custom constructors for. This is messy and reduces readability.
With closure support, this can be shortened: