Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate error page #78

Merged
merged 14 commits into from
Feb 3, 2024
Merged

Conversation

hsglc
Copy link
Contributor

@hsglc hsglc commented Jan 29, 2024

This PR is related to the #61 . It handles any runtime errors and non-existent pages.

Copy link

vercel bot commented Jan 29, 2024

@hslc00 is attempting to deploy a commit to the Trendyol Gurubu Team Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gurubu ✅ Ready (Inspect) Visit Preview 💬 1 unresolved
✅ 5 resolved
Feb 3, 2024 8:19pm

@armagandalkiran
Copy link
Collaborator

Hi! it seems like build is failed. Can you run build in local too and check it ?

@hsglc
Copy link
Contributor Author

hsglc commented Jan 30, 2024

There were typos. I fixed.

@armagandalkiran armagandalkiran linked an issue Jan 30, 2024 that may be closed by this pull request
@aahmetcakir
Copy link
Contributor

I added some comment on vercel can you fix these? @hsglc

@hsglc
Copy link
Contributor Author

hsglc commented Jan 31, 2024

I added some comment on vercel can you fix these? @hsglc

I fixed them.

@aahmetcakir
Copy link
Contributor

I resolved comments on vercel I think you missed one @hsglc

@hsglc
Copy link
Contributor Author

hsglc commented Jan 31, 2024

I resolved comments on vercel I think you missed one @hsglc

it's fixed. fyi @aahmetcakir

@armagandalkiran
Copy link
Collaborator

armagandalkiran commented Feb 1, 2024

this pr -> https://gurubu-k0psdm21m-trendyol-gurubu-team.vercel.app/create/room
production -> https://gurubu.vercel.app/create/room

You can compare the changes above i think there is a problem with line-height too.

Due to changing variables it affects all of the pages you should change all of the pages variable names or just add the new ones without changing current variables. This can break all the UI. My suggestion is only add new ones and do not change current variables or just do not use variable if it not exists it is up to you.

@hsglc
Copy link
Contributor Author

hsglc commented Feb 1, 2024

this pr -> https://gurubu-k0psdm21m-trendyol-gurubu-team.vercel.app/create/room production -> https://gurubu.vercel.app/create/room

You can compare the changes above i think there is a problem with line-height too.

Due to changing variables it affects all of the pages you should change all of the pages variable names or just add the new ones without changing current variables. This can break all the UI. My suggestion is only add new ones and do not change current variables or just do not use variable if it not exists it is up to you.

yes you're right. I missed something when I was updating and also i fixed the line-height issue now, fyi.

@aahmetcakir
Copy link
Contributor

LGTM @hsglc we can merge now 🚀

aahmetcakir
aahmetcakir previously approved these changes Feb 2, 2024
@mertcanaltin
Copy link
Member

after fixing it, can you mark the problems as solved, this will be very healthy @hsglc 🎉

mertcanaltin
mertcanaltin previously approved these changes Feb 2, 2024
Copy link
Member

@mertcanaltin mertcanaltin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mertcanaltin mertcanaltin changed the title Feature/error pages feat: generate error page Feb 2, 2024
@armagandalkiran
Copy link
Collaborator

Hey @hsglc ! Could you resolve the conflict ? After that I will merge it 🚀

@hsglc
Copy link
Contributor Author

hsglc commented Feb 3, 2024

Hey @hsglc ! Could you resolve the conflict ? After that I will merge it 🚀

fixed.

Copy link
Collaborator

@armagandalkiran armagandalkiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved thank you for your contribution ! 🚀

@armagandalkiran armagandalkiran merged commit 1732f57 into Trendyol:main Feb 3, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Establishing Error Page Structure Displaying an error page instead of breaking the app at runtime?
5 participants