-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate error page #78
Conversation
@hslc00 is attempting to deploy a commit to the Trendyol Gurubu Team Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi! it seems like build is failed. Can you run build in local too and check it ? |
There were typos. I fixed. |
I added some comment on vercel can you fix these? @hsglc |
I fixed them. |
I resolved comments on vercel I think you missed one @hsglc |
it's fixed. fyi @aahmetcakir |
this pr -> https://gurubu-k0psdm21m-trendyol-gurubu-team.vercel.app/create/room You can compare the changes above i think there is a problem with line-height too. Due to changing variables it affects all of the pages you should change all of the pages variable names or just add the new ones without changing current variables. This can break all the UI. My suggestion is only add new ones and do not change current variables or just do not use variable if it not exists it is up to you. |
yes you're right. I missed something when I was updating and also i fixed the line-height issue now, fyi. |
LGTM @hsglc we can merge now 🚀 |
after fixing it, can you mark the problems as solved, this will be very healthy @hsglc 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hsglc ! Could you resolve the conflict ? After that I will merge it 🚀 |
fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved thank you for your contribution ! 🚀
This PR is related to the #61 . It handles any runtime errors and non-existent pages.