Handle multiple nodes #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SergiiDmytruk
commented
Apr 8, 2024
SergiiDmytruk
commented
- Revert change that made SKL work only on Fam 16h and up, so it can be used with Fam 15h or even older CPUs.
- Update configuration of DEV of each northbridge that's present.
krystian-hebel
force-pushed
the
iommu_updates
branch
3 times, most recently
from
b58b2d6
to
4304942
Compare
krystian-hebel
force-pushed
the
iommu_updates
branch
2 times, most recently
from
d2cb1b7
to
f16a0d0
Compare
SergiiDmytruk
force-pushed
the
handle-multiple-nodes
branch
from
589a643
to
951f504
Compare
…ssors" This reverts commit 335c103. Without -march=btver2 SKL can be used on AMD 15h or earlier and now that SKL more than fits into 64KiB limit, no need for such options to save a bit of space. Signed-off-by: Sergii Dmytruk <[email protected]>
DEV is specific to a northbridge, so there are multiple of them on systems with several CPU sockets. 0x18 is the device number of the first one with the rest using successive numbers (0x19, 0x1A, etc.). Signed-off-by: Sergii Dmytruk <[email protected]>
SergiiDmytruk
force-pushed
the
handle-multiple-nodes
branch
from
951f504
to
18f5358
Compare
krystian-hebel
approved these changes
Apr 17, 2024
miczyg1
reviewed
Apr 19, 2024
Comment on lines
+24
to
+26
| * There are only 5 bits (0x00..0x1f) for PCI slot number (see definition of | ||
| * PCI_DEVFN) and we start at 0x18 (DEV_PCI_DEVICE), so there is hard upper | ||
| * limit on how many nodes can exist. |
There was a problem hiding this comment.
FYI: There actually is a setting in AMD Family 10h/15h to remap those node devices to bus 0xfe and 0xff, giving a potential for up to 64 nodes: https://github.com/coreboot/coreboot/blob/4.11_branch/src/northbridge/amd/amdfam10/early_ht.c#L29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.