-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: build Qubes OS RPMs #14
Conversation
ebf9208
to
cce60b6
Compare
Signed-off-by: Sergii Dmytruk <[email protected]>
There is some garbage at the end of produced file:
According to https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/f31/f/buildflags.md#annotated-buildswatermarking This isn't that bad, when we tried to build packages with Nix those annotations somehow made it to the beginning of file, moving headers expected at offset 0 somewhere else. Still, better to not have it at all, it can impact size checks. Also, TrenchBoot/.github#6 is merged, reminder to do |
Signed-off-by: Sergii Dmytruk <[email protected]>
This prevents those sections potentially breaking the produced image if any of them will be placed in front of the binary. Signed-off-by: Sergii Dmytruk <[email protected]>
cce60b6
to
597a840
Compare
I get this
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is only CI and package metadata, not a single code change, I think this is fine if I approve this as well, so we do not need to bother the others.
Initially made Qubes OS package which builds fine, then tried to feed it to new version of Qubes OS builder and turned out that two versions aren't fully compatible. In particular v1 is happy with commits and v2 needs archive name to follow a particular scheme and doesn't accept SHA1 for a version. Committed
qubesos/
directory works with v1 builder and v2 would need some tag.Example CI job: https://github.com/TrenchBoot/secure-kernel-loader/actions/runs/7020704817
Top commit will need
s/@support-in-repo-pkgs/@master/
after TrenchBoot/.github#6 is merged.