Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sse2neon.h for Linux ARM64 #45

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

martin-g
Copy link
Contributor

@traviswheeler
Copy link
Member

Thanks for this contribution - the solution looks right to me, and I'm grateful for the suggestion. Only problem: the test fails:

 WARNING: The requested image's platform (linux/arm64/v8) does not match the detected host platform (linux/amd64/v3) and no specific platform was requested
  g++ -std=gnu++11 -Wall -O0 -g3   -c -o NINJA/ArgumentHandler.o NINJA/ArgumentHandler.cpp
  make: g++: No such file or directory
  make: *** [<builtin>: NINJA/ArgumentHandler.o] Error 127
  Error: The process '/home/runner/work/_actions/uraimo/run-on-arch-action/v2/src/run-on-arch.sh' failed with exit code 2

I'm able to look at this in a few days, but if you see what's missing and make an update, it'll be easy for me to accept. Again: thanks!

@martin-g
Copy link
Contributor Author

I need to install g++ too !

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g martin-g force-pushed the linux-arm64-support branch from 8889590 to fb95d0b Compare February 14, 2024 07:36
@martin-g
Copy link
Contributor Author

@traviswheeler traviswheeler merged commit c4dc5e0 into TravisWheelerLab:master Feb 14, 2024
3 checks passed
@traviswheeler
Copy link
Member

Thanks for your help in getting this to work!

@markjens
Copy link

@traviswheeler Do you have plans for releasing a new version soon ?

https://github.com/Dfam-consortium/TETools/blob/1ee86d4479fe4507ae387b41b9568fccaa3f0858/getsrc.sh#L35 needs this fix to be able to provide a linux/arm64 Docker image.
Dfam-consortium/TETools#25
Thank you!

@traviswheeler
Copy link
Member

It's here now:
https://github.com/TravisWheelerLab/NINJA/releases/tag/0.99-cluster_only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is this program considering supporting the aarch64 architecture?
3 participants