Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for deprecated/obsolete identifiers #93

Open
gaurav opened this issue Nov 21, 2022 · 1 comment
Open

Add support for deprecated/obsolete identifiers #93

gaurav opened this issue Nov 21, 2022 · 1 comment
Labels
Data Source: UMLS and RxNorm issue of issues A high-level issue that collects individual issues that might have similar causes mildly important

Comments

@gaurav
Copy link
Collaborator

gaurav commented Nov 21, 2022

We've had a bunch of requests for deprecated or obsolete terms in Babel:

Note that in some cases (e.g. MONDO) deprecated terms can point to a non-deprecated term that replaces them, while in other cases (e.g. UMLS) there does not appear to be a clear mapping to a non-deprecated term.

Should we add deprecated terms to Babel? If we do that, we will need to mark them in some way so that we can ensure (1) that deprecated terms are never used as the primary identifier of a clique, and (2) so that NodeNorm and NameRes can warn users not to use deprecated terms.

This issue is to discuss whether this would be useful, what changes would be necessary in NodeNorm and NameRes to support them, and how we should go about including them.

@gaurav gaurav added this to the Babel January 2023 Release milestone Nov 21, 2022
@gaurav gaurav modified the milestones: Babel January 2023 Release, Babel April 2023 Release Mar 15, 2023
@gaurav gaurav modified the milestones: Babel April 2023 Release, Babel September Release Jun 8, 2023
@gaurav gaurav changed the title Add support for deprecated identifiers Add support for deprecated/obsolete identifiers May 13, 2024
@gaurav gaurav added the issue of issues A high-level issue that collects individual issues that might have similar causes label Oct 21, 2024
@cmungall
Copy link

cmungall commented Nov 8, 2024

Note that in some cases (e.g. MONDO) deprecated terms can point to a non-deprecated term that replaces them, while in other cases (e.g. UMLS) there does not appear to be a clear mapping to a non-deprecated term.

Not just MONDO, but any OBO ontology commits to never deleting IDs. It's not always possible to specify a replacement of course.

https://incatools.github.io/ontology-access-kit/guide/obsoletion.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Source: UMLS and RxNorm issue of issues A high-level issue that collects individual issues that might have similar causes mildly important
Projects
None yet
Development

No branches or pull requests

2 participants