Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Maven build support #28

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

meiMingle
Copy link

No description provided.

@Traneptora
Copy link
Owner

I'm not sure where you're getting com.github.traneptora from - also you need to squash the commits.

@meiMingle
Copy link
Author

I'm not sure where you're getting com.github.traneptora from

I just defined it based on your github account name, do you have a suggested GroupId?

also you need to squash the commits.

Yes, I will do this later

@Traneptora
Copy link
Owner

I just defined it based on your github account name, do you have a suggested GroupId?

As far as I understand it should be equal to the package name directly above the project. The project's base package is com.traneptora.jxlatte so as far as I understand, com.traneptora should be used. Although I may be mistaken.

@Traneptora
Copy link
Owner

Update: I forgot to rename the package when I changed my username, but it should be renamed now.

@meiMingle
Copy link
Author

Now, I have finished modifying

@Traneptora
Copy link
Owner

pom.xml is missing a newline at the end of the file. Otherwise, I can test this today.

@meiMingle
Copy link
Author

pom.xml is missing a newline at the end of the file. Otherwise, I can test this today.

Yes, I just fixed it

@Traneptora
Copy link
Owner

Traneptora commented Jan 25, 2024

Make sure you squash the commits, then I can review.

@BuZZ-dEE
Copy link

Make sure you squash the commits, then I can review.

@Traneptora In GitLab you can squash it when you accept the merge request. I would assume the same is possible on GitHub. Is it not?

@Traneptora
Copy link
Owner

I only use Rebase And Merge because Squash and Merge makes silly commit messages. As such, I request a squash before I will review it.

@meiMingle
Copy link
Author

Commits has been squashed.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@meiMingle meiMingle force-pushed the main-mavenize branch 2 times, most recently from eb51f45 to cfe6074 Compare November 13, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants