-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Maven build support #28
base: main
Are you sure you want to change the base?
Conversation
I'm not sure where you're getting |
I just defined it based on your github account name, do you have a suggested GroupId?
Yes, I will do this later |
388d23d
to
3495672
Compare
As far as I understand it should be equal to the package name directly above the project. The project's base package is |
Update: I forgot to rename the package when I changed my username, but it should be renamed now. |
3495672
to
c6d25c0
Compare
Now, I have finished modifying |
|
c6d25c0
to
93ba41b
Compare
Yes, I just fixed it |
Make sure you squash the commits, then I can review. |
@Traneptora In GitLab you can squash it when you accept the merge request. I would assume the same is possible on GitHub. Is it not? |
I only use Rebase And Merge because Squash and Merge makes silly commit messages. As such, I request a squash before I will review it. |
d5e20f9
to
8245a88
Compare
Commits has been squashed. |
8245a88
to
a8d6ffc
Compare
eb51f45
to
cfe6074
Compare
cfe6074
to
8b05563
Compare
No description provided.