Ensure nested working directory from command proto are created #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command protocol spec allows for clients to send `Command.working_directory` that could be nested and not downloaded from other digests. This behavior has been seen with reclient implementations. This change will now create all directories from `Command.working_directory` at the root of `RunningActionImpl.work_directory`.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Closing for now due to misconfiguration with reclient made this look like a bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command protocol spec allows for clients to send
Command.working_directorythat could be nested and not downloaded from other digests. This behavior has been seen with reclient implementations. This change will now create all directories fromCommand.working_directoryat the root ofRunningActionImpl.work_directory.Description
Please include a summary of the changes and the related issue. Please also
include relevant motivation and context.
Fixes # (issue)
Type of change
Please delete options that aren't relevant.
not work as expected)
How Has This Been Tested?
Unit tested.
Reclient setup with chromium on macosx.
Checklist
bazel test //...passes locallygit amendsee some docsThis change is