Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cargo install tag and start command #654

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Fix cargo install tag and start command #654

merged 1 commit into from
Feb 2, 2024

Conversation

blakehatch
Copy link
Member

@blakehatch blakehatch commented Feb 2, 2024 •
edited by allada
Loading

Description

Please include a summary of the changes and the related issue. Please also
include relevant motivation and context.

Fixes #652

  • This change requires a documentation update

Checklist

  • Updated documentation if needed

This change is Reviewable

@blakehatch blakehatch self-assigned this Feb 2, 2024
@vercel Vercel
Copy link

vercel bot commented Feb 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nativelink-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 9:42pm

tyr-one
tyr-one approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@tyr-one tyr-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 0 of 1 LGTMs obtained, and pending CI: asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), macos-13 (waiting on @blakehatch)

tyr-one
tyr-one approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@tyr-one tyr-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 LGTMs obtained, and pending CI: asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), macos-13 (waiting on @blakehatch)

adam-singer
adam-singer approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@adam-singer adam-singer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: 0 of 1 LGTMs obtained, and pending CI: docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04) (waiting on @blakehatch)

blakehatch
blakehatch commented Feb 2, 2024
View reviewed changes
Copy link
Member Author

@blakehatch blakehatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

@blakehatch blakehatch merged commit 89313ff into TraceMachina:main Feb 2, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyr-one tyr-one tyr-one approved these changes

@adam-singer adam-singer adam-singer approved these changes

@MarcusSorealheis MarcusSorealheis Awaiting requested review from MarcusSorealheis

Assignees

@blakehatch blakehatch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update cas to nativelink in docs site for running instructions
3 participants
@blakehatch @adam-singer @tyr-one